Fix test suite to be run in PHP5 and PHP7 env #58
Conversation
|
Well, I thought the build would be a success… But HHVM fails. From what I can see, in the build log, the problem is at the infrastructure level, no? Can we improve this situation from our code? Or is it on the Travis-CI team side? |
|
Well… the hhvm build is successful, but now the php-5.3 one is broken :( |
|
Just a suggestion: Looking at PHPs overview of eol versions, perhaps the tests should drop everything < 5.6 as that is the oldest still supported? PHP 5.3 entered eol almost 3 years ago, |
|
Yes we can drop EOL'ed versions. |
|
It's my day, I guess: PHP-7.0 build is now the only broken… But I don't know what we can do to make it green. |
| @@ -2,7 +2,17 @@ | |||
|
|
|||
| namespace EmailReplyParser\Tests; | |||
|
|
|||
| class TestCase extends \PHPUnit_Framework_TestCase | |||
| if (class_exists('PHPUnit_Framework_TestCase')) { | |||
There was a problem hiding this comment.
if both classes exist at the same, we should use the namespaced one IMO
There was a problem hiding this comment.
Agreed. I was quickly trying something first.
composer.json
Outdated
| @@ -23,5 +23,8 @@ | |||
| "branch-alias": { | |||
| "dev-master": "2.5-dev" | |||
| } | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^4.8" | |||
There was a problem hiding this comment.
you should at least allow 4.8 or 5.7. 4.8 is not properly supporting PHP 7, and is unmaintained.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace EmailReplyParser\Tests; | |||
|
|
|||
| class TestCase extends \PHPUnit_Framework_TestCase | |||
| abstract class TestCase extends \PHPUnit\Framework\TestCase | |||
There was a problem hiding this comment.
this actually requires 4.8.35+, not any 4.8.
willdurand
force-pushed
the
fix_test_suite
branch
from
c6b129d to
1f47f39
Compare
|
@willdurand For my understanding, how did you find the good recipe for a stronger .travis.yml? |
|
I merged a similar PR (willdurand/Hateoas#249) from @goetas before :) |
|
:) |
|
btw, i wrote this "doc" some time ago to make travis run phpunit for 5.3-7.3: eventum/rpc#2 |
Add a compatibility layer to be able to run the test suite in PHP5 or PHP7 env. This will fix Travis builds.