Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nightly builds - WPB-14822 #2241

Merged
merged 3 commits into from
Dec 4, 2024
Merged

fix: nightly builds - WPB-14822 #2241

merged 3 commits into from
Dec 4, 2024

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Dec 4, 2024

BugWPB-14822 Nightly build failed

Issue

Nightly tests failed to execute properly yesterday, as the command bundle exec fastlane test_frameworks folders: all:true

The code expects either true or 1 as a String

Solution:

Accept boolean instead for options[:all]

Testing

  • Trigger a new nightly
  • Execute locallybundle exec fastlane test_frameworks folders: all:true

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe changed the title fix: nightly builds fix: nightly builds - WPB-14822 Dec 4, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3a14e91.

♻️ This comment has been updated with latest results.

@netbe netbe enabled auto-merge (squash) December 4, 2024 11:12
@netbe
Copy link
Collaborator Author

netbe commented Dec 4, 2024

actually running nigthly tests can only be tried once this is merged

@netbe netbe disabled auto-merge December 4, 2024 20:40
@netbe netbe merged commit 1222246 into release/cycle-3.114 Dec 4, 2024
10 of 11 checks passed
@netbe netbe deleted the fix/nightly branch December 4, 2024 20:41
zenkins pushed a commit that referenced this pull request Dec 4, 2024
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants