Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nightly builds - WPB-14822 #2250

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: nightly builds - WPB-14822 #2250

merged 1 commit into from
Dec 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 4, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-14822 Nightly build failed

Issue

Nightly tests failed to execute properly yesterday, as the command bundle exec fastlane test_frameworks folders: all:true

The code expects either true or 1 as a String

Solution:

Accept boolean instead for options[:all]

Testing

  • Trigger a new nightly
  • Execute locallybundle exec fastlane test_frameworks folders: all:true

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions github-actions bot added cherry-pick echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... labels Dec 4, 2024
@netbe netbe self-requested a review December 4, 2024 20:43
@netbe netbe merged commit bd35b9e into develop Dec 4, 2024
2 of 3 checks passed
@netbe netbe deleted the fix/nightly-cherry-pick branch December 4, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant