Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve todos in WireAnalytics - WPB-11881 #2253

Merged
merged 52 commits into from
Dec 9, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Dec 5, 2024

TaskWPB-11881 move Wirelogger to WireFoundation

Issue

Following up on PR #1938
this PR adds WireLogging as a dependency to WireAnalytics and WireDatadog and removes a workaround for logging.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 5, 2024
@caldrian caldrian requested review from netbe and samwyndham December 6, 2024 08:37
…8-57ac870d7a6aa55c91ab6a4edd8cd2ed7fa5f126' into chore/resolve-todos-WPB-10941
Base automatically changed from chore/move-WireLogger-into-WireFoundation-WPB-10941 to develop December 6, 2024 12:43
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@caldrian caldrian enabled auto-merge December 6, 2024 15:24
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, left a couple comments mostly for understanding before approving

.github/workflows/_reusable_run_tests.yml Outdated Show resolved Hide resolved
WireAnalytics/Package.swift Show resolved Hide resolved
fastlane/framework.rb Outdated Show resolved Hide resolved
@caldrian caldrian added this pull request to the merge queue Dec 9, 2024
Merged via the queue into develop with commit d03ca97 Dec 9, 2024
29 checks passed
@caldrian caldrian deleted the chore/resolve-todos-WPB-10941 branch December 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants