Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extract WireLogger into Swift package - WPB-11881 #1938

Merged
merged 35 commits into from
Dec 6, 2024
Merged

chore: extract WireLogger into Swift package - WPB-11881 #1938

merged 35 commits into from
Dec 6, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 16, 2024 •
edited by github-actions bot
Loading

TaskWPB-11881 move Wirelogger to WireFoundation

Issue

In order to be able to use WireLogger from Swift packages, this PR moves all WireLogger related code (except WireLoggerObjC) from WireSystem to its own target WireLogging.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Sep 16, 2024
@caldrian caldrian changed the title chore: move WireLogger into WireFfoundation - WPB-10941 chore: move WireLogger into WireFoundation - WPB-10941 Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Test Results

   19 files     20 suites   12m 32s ⏱️
8 619 tests 8 588 ✅ 31 💤 0 ❌
8 640 runs  8 609 ✅ 31 💤 0 ❌

Results for commit 9251e11.

♻️ This comment has been updated with latest results.

@caldrian caldrian added the WIP label Sep 16, 2024
@caldrian caldrian marked this pull request as draft September 16, 2024 19:03
@netbe netbe mentioned this pull request Oct 2, 2024
Merged
6 tasks
@netbe netbe self-requested a review October 4, 2024 09:31
netbe
netbe reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments, but otherwise good we should move forward on this, as it's needed on multiple packages

WireFoundation/Sources/WireFoundation/Logging/SystemLogger.swift Outdated Show resolved Hide resolved
WireUI/Package.resolved Outdated Show resolved Hide resolved
wire-ios-system/Source/Logging/WireLogger.swift Outdated Show resolved Hide resolved
@echoes-hq echoes-hq bot removed the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Oct 20, 2024
@echoes-hq echoes-hq bot added echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. and removed echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Nov 20, 2024
@caldrian caldrian changed the title chore: move WireLogger into WireFoundation - WPB-10941 chore: move WireLogger into WireFoundation - WPB-11881 Nov 20, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Nov 20, 2024
@caldrian caldrian changed the base branch from develop to release/cycle-3.114 November 21, 2024 22:22
@echoes-hq echoes-hq bot added echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Nov 21, 2024
@caldrian caldrian changed the base branch from release/cycle-3.114 to fix/sourcery-stencils-WPB-11881 November 22, 2024 14:55
Base automatically changed from fix/sourcery-stencils-WPB-11881 to release/cycle-3.114 November 22, 2024 15:34
@caldrian caldrian marked this pull request as ready for review November 26, 2024 09:44
@caldrian caldrian marked this pull request as draft November 26, 2024 09:44
@netbe netbe changed the base branch from release/cycle-3.114 to develop November 28, 2024 13:45
@echoes-hq echoes-hq bot added echoes: unplanned/quick-win Work items completed to address issues quickly, without extensive planning. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. labels Nov 28, 2024
@caldrian caldrian removed echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. labels Dec 2, 2024
@caldrian caldrian changed the title chore: move WireLogger into WireFoundation - WPB-11881 chore: extract WireLogger into Swift package - WPB-11881 Dec 4, 2024
@caldrian caldrian requested a review from netbe December 4, 2024 15:50
@caldrian
Copy link
Contributor Author

caldrian commented Dec 4, 2024

unless caldrian you want to go the extra step of introducing WireLogger as it's on framework

made WireLogging a separate Swift package @netbe

@caldrian caldrian mentioned this pull request Dec 5, 2024
Merged
6 tasks
@caldrian caldrian removed the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 5, 2024
netbe
netbe reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we could keep WireLogging inside WireFoundation but this works too for now.

a couple small things remain:

  1. the detection for .github/workflows/test_pr_changes.yml
  2. to_scheme in framework.rb
  3. the AllTests testplan for WireLogging

WireLogging/Sources/WireLoggingSupport/WireDomainPackage.swift Outdated Show resolved Hide resolved
fastlane/framework.rb Outdated Show resolved Hide resolved
fastlane/framework.rb Show resolved Hide resolved
netbe
netbe approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@caldrian caldrian requested a review from KaterinaWire December 6, 2024 11:15
@caldrian caldrian added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit d7a70a3 Dec 6, 2024
12 checks passed
@caldrian caldrian deleted the chore/move-WireLogger-into-WireFoundation-WPB-10941 branch December 6, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaterinaWire KaterinaWire KaterinaWire approved these changes

@netbe netbe netbe approved these changes

Assignees

@caldrian caldrian

Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caldrian @netbe @KaterinaWire