fix(routing): don't access Request headers (#12498)

Co-authored-by: ascorbic <213306+ascorbic@users.noreply.github.com>
withastro · Nov 22, 2024 · b140a3f · b140a3f
1 parent 3bed805
commit b140a3f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/unlucky-kids-compete.md b/.changeset/unlucky-kids-compete.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a regression where Astro was trying to access `Request.headers`
diff --git a/packages/astro/src/core/middleware/noop-middleware.ts b/packages/astro/src/core/middleware/noop-middleware.ts
@@ -1,7 +1,8 @@
 import type { MiddlewareHandler } from '../../@types/astro.js';
 import { NOOP_MIDDLEWARE_HEADER } from '../constants.js';
 
-export const NOOP_MIDDLEWARE_FN: MiddlewareHandler = (ctx, next) => {
-	ctx.request.headers.set(NOOP_MIDDLEWARE_HEADER, 'true');
-	return next();
+export const NOOP_MIDDLEWARE_FN: MiddlewareHandler = async (_ctx, next) => {
+	const response = await next();
+	response.headers.set(NOOP_MIDDLEWARE_HEADER, 'true');
+	return response;
 };