Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): don't access Request headers #12498

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Nov 22, 2024

Changes

Closes #12495
Closes #12496
Closes #12497
Closes PLT-2667

Testing

CI should pass
I tested it with a local reproduction. Can't see the warning anymore.

Docs

N/A

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 9ee7194

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 22, 2024
@ematipico ematipico force-pushed the fix/regression-in-noop-middleware branch from 16864dc to 9ee7194 Compare November 22, 2024 09:50
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #12498 will not alter performance

Comparing fix/regression-in-noop-middleware (9ee7194) with main (a23985b)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico merged commit b140a3f into main Nov 22, 2024
15 checks passed
@ematipico ematipico deleted the fix/regression-in-noop-middleware branch November 22, 2024 10:26
This was referenced Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
2 participants