Improve astro check #3906
Merged
Improve astro check #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c0494a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Ugh, tests are failing on Windows.. will investigate EDIT: It turns out that |
matthewp
reviewed
Jul 18, 2022
| bold(red(`${result.errors} ${result.errors === 1 ? 'error' : 'errors'}`)), | ||
| bold(yellow(`${result.warnings} ${result.warnings === 1 ? 'warning' : 'warnings'}`)), | ||
| dim(`${result.hints} ${result.hints === 1 ? 'hint' : 'hints'}\n`), | ||
| ].join(`\n${dim('-')} `) |
|
lgtm overall. Needs a changeset. Also you mentioned getting the examples to run astro check, are you intending to do that in another PR? |
Yep, part of #3940 I'm thinking. Thank you for the review! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This improves and fixes
astro checkin many ways:Result:
Before
After
Testing
Added some simple tests that
astro checkworksDocs
N/A