Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the alignment of errors when the source code used tab for indent #3948

Closed

Conversation

jwickers
Copy link

Signed-off-by: Jeremy Wickersheimer jwickers@gmail.com

Changes

Fix the alignment of errors when the source code used tab for indentation. See screenshots below.

  • before

Screen Shot 2022-07-17 at 18 07 57

  • after

Screen Shot 2022-07-17 at 18 07 28

Testing

Tested on my code base where the bug was noticed.

Docs

Bugfix, no doc changes.

jwickers added 2 commits July 17, 2022 18:03
…tion.

Signed-off-by: Jeremy Wickersheimer <jwickers@gmail.com>
Signed-off-by: Jeremy Wickersheimer <jwickers@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2022

🦋 Changeset detected

Latest commit: e87f462

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
astro Minor
@e2e/astro-component Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 17, 2022
@Princesseuh
Copy link
Member

Hello, thank you very much for making a PR! This change is already covered by #3906 (and is now merged in). As such, I will be closing this one

Thank you again for contributing to the project, especially such a rarely visited part of the codebase 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants