Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the alignment of errors when the source code used tab for indent #3948

Closed
wants to merge 2 commits into from
+6 −1
Closed

Fix the alignment of errors when the source code used tab for indent #3948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a8316
Fix the alignment of errors when the source code used tab for indenta…
jwickers Jul 17, 2022
e87f462
Add changeset
jwickers Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-frogs-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': minor
---

Fix the alignment of errors when the source code used tab for indentation
2 changes: 1 addition & 1 deletion packages/astro/src/cli/check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export async function check(astroConfig: AstroConfig) {
let str = diag.text.substring(startOffset, endOffset - 1);
const lineNumStr = d.range.start.line.toString();
const lineNumLen = lineNumStr.length;
console.error(`${bgWhite(black(lineNumStr))} ${str}`);
console.error(`${bgWhite(black(lineNumStr))} ${str.replaceAll('\t', ' ')}`);
let tildes = generateString('~', d.range.end.character - d.range.start.character);
let spaces = generateString(' ', d.range.start.character + lineNumLen - 1);
console.error(` ${spaces}${bold(red(tildes))}\n`);
Expand Down