Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix route mismatching #7319

Closed
wants to merge 9 commits into from
Closed

Conversation

JerryWu1234
Copy link
Contributor

Changes

Regex sometimes fails to match. I splice the complete path and match it to ensure that it is completely correct.
#6968

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: 7e85979

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 7, 2023
@JerryWu1234 JerryWu1234 marked this pull request as draft June 7, 2023 07:18
@JerryWu1234 JerryWu1234 marked this pull request as ready for review June 8, 2023 06:43
@@ -1,3 +1,4 @@
import { object } from 'zod';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import should be removed

.changeset/witty-grapes-jam.md Outdated Show resolved Hide resolved
.changeset/witty-grapes-jam.md Outdated Show resolved Hide resolved
packages/astro/src/core/render/route-cache.ts Show resolved Hide resolved
@JerryWu1234
Copy link
Contributor Author

Thank you for reviewing the code.
I’m a little busy today.
I will fix it next Monday. Welcome comments.

@natemoo-re
Copy link
Member

I'm going to close this as #7694 fixed the same issue! Thanks for opening the PR, though!

@natemoo-re natemoo-re closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants