Fix routing behavior when getStaticPaths params include hyphens #7694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f65a173 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Jul 17, 2023
ematipico
approved these changes
Jul 18, 2023
Merged
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getStaticPathsimplementation includes a keyed objectRouteManifest, the generatedroute.patterndoesn't always match the generated routes due to hyphenization.route.patternlogic to account for hyphens, the correct fix is to update ourgetStaticPaths.keyedimplementation to only store the final, generated pathname of the route. This removes any mismatchedkeys <=> datarelationship. Hyphens are no longer relevant!/route/[a]-[b]Testing
Test added, existing tests should pass
Docs
Bug fix only