Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pdfjs-dist to 2.5.207 #687

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Update pdfjs-dist to 2.5.207 #687

merged 2 commits into from
Nov 26, 2020

Conversation

wojtekmaj
Copy link
Owner

Closes #686

@wojtekmaj
Copy link
Owner Author

@toszcze Wanna be a beta tester of this one? ;)

@wojtekmaj wojtekmaj self-assigned this Nov 20, 2020
@wojtekmaj wojtekmaj added the evergreening Keeps the project up to date label Nov 20, 2020
@toszcze
Copy link

toszcze commented Nov 20, 2020

@wojtekmaj Sure! :)

@toszcze
Copy link

toszcze commented Nov 20, 2020

@wojtekmaj I'm sorry, but I'm not sure how I can install this version using npm. I've tried npm i git+ssh://git@github.com:wojtekmaj/react-pdf.git#pdfjs-dist-2.5.207, but it failed (Couldn't find the node_modules state file - running an install might help).

@toszcze
Copy link

toszcze commented Nov 20, 2020

@wojtekmaj I built the module locally, linked it into my project, but I'm getting the following message when I try to build my project:

ERROR in ../react-pdf/dist/esm/entry.webpack.js
Module build failed (from ./node_modules/eslint-loader/index.js):
Error: Cannot find module 'eslint-config-wojtekmaj/react'
Referenced from: /../projekty/react-pdf/.eslintrc.json

@wojtekmaj
Copy link
Owner Author

wojtekmaj commented Nov 23, 2020 •
edited
Loading

@toszcze I released this PR as 5.1.0-beta. You can use npm install react-pdf@next or yarn add react-pdf@next to try it out.

@toszcze
Copy link

toszcze commented Nov 25, 2020

@wojtekmaj It works for me.

@wojtekmaj wojtekmaj merged commit eec72c5 into master Nov 26, 2020
@wojtekmaj wojtekmaj deleted the pdfjs-dist-2.5.207 branch November 26, 2020 05:43
@wojtekmaj wojtekmaj mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wojtekmaj wojtekmaj

Labels
evergreening Keeps the project up to date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pdf.js to 2.5.207
2 participants
@wojtekmaj @toszcze