Update pdfjs-dist to 2.6.347

[andi-dev]

Hey guys, I don't know what you think about keeping the pdfjs version up-to-date, and I honestly can't overlook if this could break anything in react-pdf. However I need to run react-pdf with a newer pdfjs version, and I would prefer not to use a fork...

If there is anything I can further do, to make sure this could make it into upstream I'd be happy to help.

[wojtekmaj]

I honestly can't overlook if this could break anything in react-pdf

Unfortunately Mozilla is yet to discover the wonders of semver. It was pretty common to introduce breaking changes in previous "minor" releases.

• Update pdfjs-dist to 2.5.207 #687 was relatively easy but required some changes on our side due to ES modules being suddenly shipped by default
• Update pdfjs-dist to 2.4.456 #583 changed previously public pageIndex to private _pageIndex breaking our tests.

That's why pdfjs-dist dependency version is strictly set. That being said, every pdfjs-dist update needs to be thoroughly tested with React-PDF.

[wojtekmaj]

This update looks clean though!

One more request. Could you also run yarn in test directory so we don't end up with outdated lockfiles? Thanks!

[andi-dev]

@wojtekmaj hey, thanks for the feedback, and yes I will quickly run yarn in test.

Btw. you mention in #748 that the pdfjs update is included in react-pdf-5.3.0, but this PR is not yet merged. So it is not included in the beta right? Once it is included in the beta I will install it an help testing.

[andi-dev]

@wojtekmaj I updated this PR with the updated test/yarn.lock

[wojtekmaj]

Btw. you mention in #748 that the pdfjs update is included in react-pdf-5.3.0, but this PR is not yet merged. So it is not included in the beta right? Once it is included in the beta I will install it an help testing.

Actually it is included in the beta. Just because something isn't on master doesn't mean it's not somewhere else (in this case, next branch) :)

[wojtekmaj]

Looks like we're good here. Thanks!