-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jaeger/1.64.0 package update #36029
jaeger/1.64.0 package update #36029
Conversation
octo-sts
bot
commented
Dec 6, 2024
Gen AI suggestions to solve the build error: • Detected Error: "LuLoader2" is not exported by "../../node_modules/react-icons/lu/index.mjs" • Error Category: Dependency/Build • Failure Point: UI build step in jaeger-all-in-one subpackage, specifically in LoadingIndicator.tsx • Root Cause Analysis: The build is failing because it's trying to import a React icon component (LuLoader2) that doesn't exist in the specified version of react-icons package. • Suggested Fix:
// Replace
import { LuLoader2 } from 'react-icons/lu';
// With one of these alternatives
import { LuLoader } from 'react-icons/lu';
// or
import { AiOutlineLoading } from 'react-icons/ai';
pipeline:
- runs: |
if [[ "${{range.key}}" = "all-in-one" ]]; then
yarn add react-icons@latest
yarn install --frozen-lockfile --cwd jaeger-ui
cd jaeger-ui/packages/jaeger-ui/build
yarn build
fi • Explanation: The error occurs because the code is trying to use an icon component that isn't available in the installed version of react-icons. Either using an alternative icon that exists in the current package version or updating to a newer version containing the desired icon will resolve the build failure. • Additional Notes:
• References:
|
06c9529
to
f64b04a
Compare
Gen AI suggestions to solve the build error: • Detected Error: "LuLoader2" is not exported by "../../node_modules/react-icons/lu/index.mjs" • Error Category: Dependency/Build • Failure Point: UI build process in the jaeger-all-in-one subpackage, specifically in LoadingIndicator.tsx • Root Cause Analysis:
• Suggested Fix:
// Change from
import { LuLoader2 } from 'react-icons/lu';
// To either
import { Loader2 as LuLoader2 } from 'react-icons/lu';
// or use a different loading icon
import { CgSpinner } from 'react-icons/cg';
{
"dependencies": {
"react-icons": "^4.12.0"
}
} • Explanation: • Additional Notes:
• References:
|
Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
f64b04a
to
4eaba7f
Compare
Gen AI suggestions to solve the build error: Based on the error output, I'll provide a structured analysis and solution: • Detected Error:
• Error Category: Dependency/Build • Failure Point: • Root Cause Analysis:
• Suggested Fix: pipeline:
- runs: |
cd jaeger-ui/packages/jaeger-ui
sed -i 's/import { LuLoader2 } from '\''react-icons\/lu'\''/import { AiOutlineLoading } from '\''react-icons\/ai'\''/' src/components/common/LoadingIndicator.tsx
sed -i 's/LuLoader2/AiOutlineLoading/' src/components/common/LoadingIndicator.tsx • Explanation: • Additional Notes:
• References:
This fix should allow the build to complete successfully while maintaining the intended functionality of the loading indicator component. |
Related with the same build failure: #36694 |
superseded by #39045 |