Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaeger/1.64.0 package update #36029

Closed
wants to merge 1 commit into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 6, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 6, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 6, 2024

Gen AI suggestions to solve the build error:

• Detected Error: "LuLoader2" is not exported by "../../node_modules/react-icons/lu/index.mjs"

• Error Category: Dependency/Build

• Failure Point: UI build step in jaeger-all-in-one subpackage, specifically in LoadingIndicator.tsx

• Root Cause Analysis: The build is failing because it's trying to import a React icon component (LuLoader2) that doesn't exist in the specified version of react-icons package.

• Suggested Fix:

  1. Modify src/components/common/LoadingIndicator.tsx to use the correct icon import:
// Replace
import { LuLoader2 } from 'react-icons/lu';

// With one of these alternatives
import { LuLoader } from 'react-icons/lu';
// or
import { AiOutlineLoading } from 'react-icons/ai';
  1. Or update the react-icons package to a version that includes LuLoader2:
pipeline:
  - runs: |
      if [[ "${{range.key}}" = "all-in-one" ]]; then
        yarn add react-icons@latest
        yarn install --frozen-lockfile --cwd jaeger-ui
        cd jaeger-ui/packages/jaeger-ui/build
        yarn build
      fi

• Explanation: The error occurs because the code is trying to use an icon component that isn't available in the installed version of react-icons. Either using an alternative icon that exists in the current package version or updating to a newer version containing the desired icon will resolve the build failure.

• Additional Notes:

  • This is a UI-specific issue in the Jaeger frontend build
  • The error is not related to the core Jaeger functionality
  • Alternative loading icons can be used without impacting core functionality
  • Consider adding explicit version pins for UI dependencies to prevent similar issues

• References:

@mamccorm mamccorm force-pushed the wolfictl-e805fcf4-293c-4916-9c9e-9bae097d0d1a branch from 06c9529 to f64b04a Compare December 7, 2024 03:09
Copy link
Contributor Author

octo-sts bot commented Dec 7, 2024

Gen AI suggestions to solve the build error:

• Detected Error: "LuLoader2" is not exported by "../../node_modules/react-icons/lu/index.mjs"

• Error Category: Dependency/Build

• Failure Point: UI build process in the jaeger-all-in-one subpackage, specifically in LoadingIndicator.tsx

• Root Cause Analysis:
The build is failing because it cannot find the LuLoader2 icon in the react-icons/lu package. This likely indicates either:

  1. An incorrect import statement
  2. A missing or incompatible react-icons version
  3. A breaking change in react-icons package

• Suggested Fix:

  1. Update the LoadingIndicator.tsx file to use the correct icon import:
// Change from
import { LuLoader2 } from 'react-icons/lu';

// To either
import { Loader2 as LuLoader2 } from 'react-icons/lu';
// or use a different loading icon
import { CgSpinner } from 'react-icons/cg';
  1. Add react-icons as an explicit dependency in package.json:
{
  "dependencies": {
    "react-icons": "^4.12.0"
  }
}

• Explanation:
The error suggests a mismatch between the imported icon name and what's actually exported by react-icons. The fix either corrects the import name or switches to a known working icon component.

• Additional Notes:

  • React Icons sometimes changes their exports between versions
  • Consider adding a lockfile to prevent dependency resolution issues
  • The build system shows multiple warnings about bundle sizes which could be addressed separately

• References:

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@mamccorm mamccorm force-pushed the wolfictl-e805fcf4-293c-4916-9c9e-9bae097d0d1a branch from f64b04a to 4eaba7f Compare December 12, 2024 01:44
Copy link
Contributor Author

octo-sts bot commented Dec 12, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a structured analysis and solution:

• Detected Error:

"LuLoader2" is not exported by "../../node_modules/react-icons/lu/index.mjs", imported by "src/components/common/LoadingIndicator.tsx"

• Error Category: Dependency/Build

• Failure Point:
UI build step during the Jaeger all-in-one package compilation, specifically in LoadingIndicator.tsx component

• Root Cause Analysis:
The build is failing because it's trying to use the LuLoader2 icon from react-icons/lu which either:

  1. Doesn't exist in the version being installed
  2. Has been renamed/moved in a recent version
  3. Is not properly exported from the package

• Suggested Fix:
Replace the import with a working alternative. Add this to the package.json patches:

pipeline:
  - runs: |
      cd jaeger-ui/packages/jaeger-ui
      sed -i 's/import { LuLoader2 } from '\''react-icons\/lu'\''/import { AiOutlineLoading } from '\''react-icons\/ai'\''/' src/components/common/LoadingIndicator.tsx
      sed -i 's/LuLoader2/AiOutlineLoading/' src/components/common/LoadingIndicator.tsx

• Explanation:
The fix replaces the problematic icon import with a known working alternative from the Ant Design icon set (react-icons/ai). This should resolve the build error while maintaining the loading indicator functionality.

• Additional Notes:

  • The error is occurring during the Vite build process
  • This appears to be a UI component dependency issue rather than a core functionality problem
  • The fix maintains the loading indicator functionality while using a different icon from a more stable icon set

• References:

This fix should allow the build to complete successfully while maintaining the intended functionality of the loading indicator component.

@hbh7
Copy link
Member

hbh7 commented Dec 18, 2024

Related with the same build failure: #36694

@hbh7 hbh7 added help wanted Extra attention is needed blocked indicates there are blocking issues that need to be addressed before progress can be made interrupt eng:ecosystems labels Dec 18, 2024
@cmwilson21 cmwilson21 assigned philroche and unassigned jvanzyl Jan 6, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 8, 2025

superseded by #39045

@octo-sts octo-sts bot closed this Jan 8, 2025
@octo-sts octo-sts bot deleted the wolfictl-e805fcf4-293c-4916-9c9e-9bae097d0d1a branch January 9, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr blocked indicates there are blocking issues that need to be addressed before progress can be made eng:ecosystems help wanted Extra attention is needed interrupt request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants