Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaeger/1.65.0 package update #39045

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 8, 2025

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jan 8, 2025
@octo-sts octo-sts bot mentioned this pull request Jan 8, 2025
Copy link
Contributor Author

octo-sts bot commented Jan 8, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also adde bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error output, I can provide a specific analysis and fix:

• Detected Error: "LuLoader2" is not exported by "../../node_modules/react-icons/lu/index.mjs"

• Error Category: Build/Dependency

• Failure Point: UI build step in the jaeger-all-in-one subpackage, specifically in the file src/components/common/LoadingIndicator.tsx

• Root Cause Analysis: The build is failing because it's trying to use the LuLoader2 icon from react-icons/lu which appears to be either missing or incorrectly exported.

• Suggested Fix:

  1. Update the LoadingIndicator.tsx import to use a different loader icon that is definitely available:
// Change from:
import { LuLoader2 } from 'react-icons/lu';

// To one of these alternatives:
import { AiOutlineLoading } from 'react-icons/ai';
// or
import { CgSpinner } from 'react-icons/cg';
  1. Alternatively, ensure the correct react-icons version is installed by adding to the pipeline:
pipeline:
  - runs: |
      if [[ "${{range.key}}" = "all-in-one" ]]; then
        cd jaeger-ui
        yarn add react-icons@latest
        yarn install --frozen-lockfile
        cd packages/jaeger-ui/build
        yarn build
      fi

• Explanation: The error indicates a missing export from the react-icons package. Either the icon name has changed in a newer version, or we need to use a different icon that's definitely available in the current version.

• Additional Notes:

  • This appears to be a UI component issue rather than a core build system problem
  • The error is occurring during the Vite build process
  • Other UI builds complete successfully before this error

• References:

@kranurag7 kranurag7 added the ai/skip-comment Stop AI from commenting on PR label Jan 8, 2025
@kranurag7
Copy link
Member

Build ID: a6968872-cfe2-4f85-9753-51e621b1c245
Error: failed to build jaeger: building group: pod failed: build failed

did not test because building group: pod failed: build failed

looks like issues from infra side, merging main so that CI runs again.

@kbsteere
Copy link
Contributor

React Icons seem to be handled differently when using yarn vs npm, yarn issue with react icons

@kbsteere kbsteere requested review from utieyin and a team January 10, 2025 22:48
@kbsteere kbsteere enabled auto-merge January 10, 2025 22:48
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Jan 10, 2025
@kbsteere kbsteere merged commit 39d7495 into main Jan 13, 2025
14 checks passed
@kbsteere kbsteere deleted the wolfictl-9257d639-bf23-45e5-b806-70ad84cfd6f9 branch January 13, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants