-
Notifications
You must be signed in to change notification settings - Fork 219
Experiment: Client side navigations in the Product Query block #7187
Experiment: Client side navigations in the Product Query block #7187
Conversation
Screen.Capture.on.2022-09-22.at.11-33-56.1.mp4Awesome works! 🚀 I created a PR to show you what I did on the filter side to support the client-side navigations #7201 I noticed that sometimes it seems that there is a problem with the diff. I didn't investigate it, I just saw the error and shared it with you, maybe you already have an idea about what could be the issue: Screen.Capture.on.2022-09-22.at.12-00-55.mp4Also, as you can see in the PR that I shared, I didn't use the |
Nice 🙂
If it happens when there are no products to show, then it's because I didn't take that use case into account yet. If not, it'd be great to have some steps to reproduce the issue.
Yes, using |
During my tests, it happened when there were no products to show 👍 |
For context: I took a look at the |
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days. |
60 days you say? 😄 |
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
Superseded by #10200. |
What
This is an experiment to bring client-side navigations to the Product Query block.
Why
Users who interact with the Product Query block may not expect a full refresh, especially when using filters.
The main goal of this PR is to make this approach available for general testing and gather feedback about it.
How
This uses the same technique as the Directives hydration of the Block Hydration Experiments but is reduced to only affect the Product Query block children. This is a similar experiment, but done with the Query Loop block.
I don't expect that interactive blocks work yet (like the Add To Cart block).
I made a video explaining how it works:
https://www.loom.com/share/ea07ee75183a4963a20afa4296656e91
Accessibility
prefers-reduced-motion
Other Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
This should be around 6kbs (
preact
with hooks is 5.4kbs).I haven't added
requestIdleCallback
yet but I plan to do so.Changelog