This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Improve transform classic product template UX #9386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/classic-template/index.tsx
assets/js/templates/revert-button/index.tsx |
|
Size Change: +782 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
gigitux
force-pushed
the
9300-improve-transform-classic-product-template-ux
branch
2 times, most recently
from
f78e0e5 to
b0bf67d
Compare
gigitux
changed the title
gigitux
added
the
focus: template
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
gigitux
force-pushed
the
9300-improve-transform-classic-product-template-ux
branch
from
4492c9f to
9393659
Compare
gigitux
force-pushed
the
9300-improve-transform-classic-product-template-ux
branch
from
9393659 to
dccdde9
Compare
gigitux
force-pushed
the
9300-improve-transform-classic-product-template-ux
branch
from
1bdce35 to
83cbd76
Compare
|
Is this the expected message on other templates aside from the |
@gigitux Does this mean that after clicking the transform button, the group block around the blockified product should be selected? |
gigitux
force-pushed
the
9300-improve-transform-classic-product-template-ux
branch
from
5bbab41 to
7730ef0
Compare
You're right, there was some issue with the label. I didn't update some logic! I fixed with 954335b. |
Yes, I will update the testing instructions to be more precise! |
Thanks! @gigitux CleanShot.2023-05-10.at.09.19.01.mp4 |
albarin
approved these changes
May 10, 2023
Thanks for your great review! 🚀 |
This was referenced May 10, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the layout of the classic product. Futhermore, it improves the UX to migrate to the blockified templates.
Please, during the review, check the mockup to see if I missed something: p6riRB-8yQ-p2
Fixes #9300 and #8853.
Screenshots
Screen.Capture.on.2023-05-08.at.18-06-07.mp4
Screen.Capture.on.2023-05-08.at.18-10-10.mov
Testing
Automated Tests
User Facing Testing
Testing Instructions for developer - not include in the testing notes
Repeat the instructions for those templates:
WooCommerce Visibility
Performance Impact
Changelog