Service command override stopped working with 1.0.0-rc1

[ateuber]

Component

agent

Describe the bug

We use the following services definition with a command statement as a workaround for a bug in Timescaledb:

services:
  database_timescale:
    image: timescale/timescaledb:latest-pg15
    command: postgres -c timescaledb.max_background_workers=0

If we don't start postgres with this max_background_workers setting, Woodpecker is unable to clone the test database.

This worked with Woodpecker 0.15.11 and stopped working with Woodpecker 1.0.0-rc1. Have there been any changes regarding this services command override?

System Info

Woodpecker 1.0.0-rc1

Additional context

No response

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[6543]

https://github.com/woodpecker-ci/woodpecker/blob/release/v0.15/pipeline/frontend/yaml/container.go#L30-L31
vs.
https://github.com/woodpecker-ci/woodpecker/blob/main/pipeline/frontend/yaml/types/container.go#L23

[6543]

ok if the v0.15 had this mentioned in the docs somewhere we have to handle it as breaking change and mention it in the cangelog and provide a migration path

[6543]

likely a regression of #1032

[6543]

@ateuber we wont add it back for safety reasons.

but you can migrate any service by lookup how the entrypoint in the original image was and combine it into it's command form (e.g. commands: <entrypoint> <cmd> ). If the entrypoint already was a shell you just have to append an s as in your case.

services:
  database_timescale:
    image: timescale/timescaledb:latest-pg15
    commands: postgres -c timescaledb.max_background_workers=0

[enobrev]

@6543, There's a typo in your response

commans:

[ateuber]

Thanks @6543, it is working with commands. That was an easy fix. 😆

[6543]

well it just has to be mentioned at the migration docs -> #2056