Add button in web-ui to trigger the deployment event #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
reviewed
Nov 12, 2022
qwerty287
changed the title
anbraten
reviewed
Nov 27, 2022
smainz
force-pushed
the
deploy-button
branch
from
57f3645
to
1816287
Compare
anbraten
approved these changes
Nov 28, 2022
smainz
force-pushed
the
deploy-button
branch
from
0372705
to
646a266
Compare
|
I improved my Vue skills and this PR is running here in production since yesterday, so it shuld work. Thanks to the reviewers. |
lafriks
reviewed
Nov 30, 2022
lafriks
approved these changes
Nov 30, 2022
|
screenshot would be nice to add to PR description |
Screenshot (Mock) is in #1412 or here (actual, german) The deploy button: The window to enter environment params and start deploymnet: |
qwerty287
reviewed
Nov 30, 2022
Co-authored-by: Lauris BH <lauris@nix.lv>
anbraten
approved these changes
Nov 30, 2022
qwerty287
reviewed
Dec 1, 2022
lafriks
reviewed
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button to the web ui to trigger the deployment event on the current pipeline.
closes #1412
The button is only active, if the current pipeline is in the state success.
I would like to get some feedback if the path I ave taken to implement this was the correct one (my first ever contact with Vue):
Is there anything I have forgotten to change?