Consistent and more descriptive naming of parameters in index.ts #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameter naming has been made more descriptive. and consistent. Change `number: number` to `pipelineNumber: number`. Rename `pipeline` to `pipelineNumber` when it refered to a pipeline number.
|
please resolve conflicts @smainz :) |
lafriks
previously requested changes
Dec 26, 2022
|
Sorry for being away for so long, but I was busy doing other things. |
6543
approved these changes
Jan 15, 2023
simmstein
pushed a commit
to simmstein/woodpecker
that referenced
this pull request
Jan 18, 2023
…dpecker-ci#1455) Parameter naming has been made more descriptive and consistent: - Change `number: number` to `pipelineNumber: number`. - Rename `pipeline` to `pipelineNumber` when it refered to a pipeline number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter naming has been made more descriptive and consistent:
number: numbertopipelineNumber: number.pipelinetopipelineNumberwhen it refered to a pipeline number.(Child of #1415)
There are still inconsistencies in the code, some methods declare the pipelineNumber as number, others as string.
Which direction to go?