Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to change status context again #674

Merged
merged 9 commits into from
Jan 29, 2022
Merged

Allow to change status context again #674

merged 9 commits into from
Jan 29, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 8, 2022

regression of #561

@6543 6543 added the server label Jan 8, 2022
@6543 6543 added this to the 0.15.0 milestone Jan 8, 2022
@6543 6543 added bug Something isn't working wip labels Jan 8, 2022
@anbraten
Copy link
Member

anbraten commented Jan 8, 2022

Why should a user be able to change it? I don't see any real benefit, so I would just remove that option completely.

@6543
Copy link
Member Author

6543 commented Jan 8, 2022 •
edited
Loading

-> edge-case: two woodpecker instances on same forge & repo

@anbraten anbraten mentioned this pull request Jan 15, 2022
Merged
@6543 6543 marked this pull request as ready for review January 29, 2022 01:58
@6543 6543 removed the wip label Jan 29, 2022
@6543 6543 requested a review from anbraten January 29, 2022 01:59
anbraten
anbraten reviewed Jan 29, 2022
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docs to match this setup as well and add a deprecation notice to the migration guide so we can remove the WOODPECKER_GITEA_CONTEXT and WOODPECKER_GITHUB_CONTEXT in the next version.

cmd/server/flags.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from anbraten January 29, 2022 15:18
anbraten
anbraten approved these changes Jan 29, 2022
View reviewed changes
docs/docs/91-migrations.md Outdated Show resolved Hide resolved
@6543 @anbraten
Update docs/docs/91-migrations.md
6ff22f4 
Co-authored-by: Anbraten <anton@ju60.de>
@6543 6543 enabled auto-merge (squash) January 29, 2022 19:24
@6543 6543 merged commit edbf6a3 into woodpecker-ci:master Jan 29, 2022
@6543 6543 deleted the status-context branch January 29, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
bug Something isn't working server skip-changelog
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@6543 @anbraten