-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused flags / options #693
Conversation
I still think we should not drop feature to set custom status context -> #674 |
normally we dont want the git clone step only to authentificate if needed (repo != public) but if you set I propose: a global bool flag (config) for all forges (similar to context-prefix) to enforce netrc generation |
so it's not handled for each remote provider but as a global option for woodpecker itself |
Why shouldn't we always use NETRC credentials to clone repos? We have that data. |
because it's sensitive data aka. an secret and if it's not within public repos it has no chance to get leaked at all |
I disagree on that. If passing the secrets is such a high security risk we have that problem for private and public repos and need to think about an alternative for both. As we only pass it to our "verified" clone image at the moment I don't see that it is a security issue. One thing I want to make clear is the current implementation of If we later want to allow the system admin to disallow public access completly, because he only want to allow access to employees for example, we can simply readd a global option, which would change the whole UI & api to always require auth, but that would be a new feature IMO. |
hmm well I think the edgecase I mention is also broken in current state - so lets remove things and if it's needed add a new flag for this specific case ... |
As a developer using an custom git server (e.g. Github Enterprise) I would like to be able to authenticate the user on repositories which are marked as public. See issue: #473 Ref: #693 (comment)
some flags where unused and / or unnecessary as they are covered by alternatives implemented in PRs of milestone 0.15.0 and just complicated the setup.
closes #681