Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to always authenticate when cloning public repositories #760

Merged
merged 12 commits into from
Feb 8, 2022

Conversation

LamaAni
Copy link
Contributor

@LamaAni LamaAni commented Feb 8, 2022

As a developer using an custom git server (e.g. Github Enterprise) I would like to be able to authenticate
the user on repositories which are marked as public.

See issue: #473

Ref: #693 (comment)

@LamaAni LamaAni mentioned this pull request Feb 8, 2022
4 tasks
@6543 6543 added enhancement improve existing features server labels Feb 8, 2022
@6543 6543 added this to the 0.15.0 milestone Feb 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #760 (656af2e) into master (5f79739) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 656af2e differs from pull request most recent head c92c412. Consider uploading reports for the commit c92c412 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   52.23%   52.23%           
=======================================
  Files          86       86           
  Lines        5940     5940           
=======================================
  Hits         3103     3103           
  Misses       2665     2665           
  Partials      172      172           
Impacted Files Coverage Δ
server/shared/procBuilder.go 86.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce4178...c92c412. Read the comment docs.

cmd/server/flags.go Outdated Show resolved Hide resolved
@anbraten anbraten changed the title Added support (flag) for authentication on public repositories Add flag to always authenticate when cloning public repositories Feb 8, 2022
Co-authored-by: Anbraten <anton@ju60.de>
@LamaAni
Copy link
Contributor Author

LamaAni commented Feb 8, 2022

@LamaAni can you add it to the documentation?

https://woodpecker-ci.org/docs/administration/server-config (https://github.com/woodpecker-ci/woodpecker/blob/master/docs/docs/30-administration/10-server-config.md)

Sure thing. Updated

cmd/server/flags.go Outdated Show resolved Hide resolved
Co-authored-by: Anbraten <anton@ju60.de>
@6543 6543 enabled auto-merge (squash) February 8, 2022 16:30
@6543 6543 merged commit f16525f into woodpecker-ci:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants