[또링] 온보딩 코드리뷰 요청합니다. #37

jnsorn · 2020-02-07T08:51:59Z

리뷰 요청드립니다. 감사합니다.. 부족한 부분이 많은데 많이 리뷰해주시면 열심히 고쳐보겠습니다!..😊

hongsii

안녕하세요, 또링~ 이번에 리뷰를 맡게 된 홍시입니다.
요구사항에 맞게 잘 구현해주셨네요! 👍
몇 가지 피드백드렸으니, 확인하셔서 반영해주세요 :)

src/main/java/model/StringValue.java

src/main/java/validator/InputValidator.java

src/main/java/controller/Controller.java

src/test/java/study/SetTest.java

src/main/java/validator/InputValidator.java

hongsii

피드백 반영을 잘 해주셨네요! 💯
사소한 피드백 몇가지 드렸으니, 참고해주세요!
이번 단계는 여기서 머지하겠습니다 :)

src/main/java/model/OperatorType.java

src/main/java/calculator/Calculator.java

kimevanjunseok added 23 commits February 5, 2020 13:28

[Add] split method

2bb20b3

[Add] substring method

e175d57

[Add] charAt method with using assertThatThrownBy

4923054

[Refactor] add class information

3b70d9f

[Docs] add README

d7d14a9

[Refactor] split test using containsExactly()

f614840

[Docs] update README

ba9a772

[Add] method to check size of Set

00b743c

[Add] method to check if Set contains value using @ParameterizedTest

4e97baa

[Add] method to check if Set contains value in all cases

370f685

[Refactor] separate charAt method

26c78d6

[Docs] update README

1a88b09

[Docs] update README about calculator

2f72d1c

[Add] function to get string from user

64f7e39

[Add] validation of input value

090387b

[Add] Test code about validation of input value

3b65b88

[Update] function to get string from user

9bcabf0

[Add] function to calculate value

ef2e8a0

[Add] Test code about function to calculate value

787dec9

[Add] function to print result

ffb2fb2

[Refactor] code separation

6635bd2

[Refactor] handle exception about divide

1a87428

[Add] Test code about divide exception function

7dc5b38

hongsii suggested changes Feb 8, 2020

View reviewed changes

jnsorn added 5 commits February 9, 2020 12:52

[Refactor] renaming of variables and method

3e96b56

[Refactor] static variables, handle NPE

e790882

[Refactor] create Expression object after validation

07e22f0

[Refactor] managing four operators as enum

1542a3a

[Refactor] simple calculation logic using enum

6d63357

hongsii approved these changes Feb 10, 2020

View reviewed changes

src/main/java/model/OperatorType.java Show resolved Hide resolved

src/main/java/model/OperatorType.java Show resolved Hide resolved

src/main/java/calculator/Calculator.java Show resolved Hide resolved

hongsii merged commit c01ad00 into woowacourse:jnsorn Feb 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[또링] 온보딩 코드리뷰 요청합니다. #37

[또링] 온보딩 코드리뷰 요청합니다. #37

jnsorn commented Feb 7, 2020

hongsii left a comment

hongsii left a comment

[또링] 온보딩 코드리뷰 요청합니다. #37

[또링] 온보딩 코드리뷰 요청합니다. #37

Conversation

jnsorn commented Feb 7, 2020

hongsii left a comment

Choose a reason for hiding this comment

hongsii left a comment

Choose a reason for hiding this comment