Code

[또링] 온보딩 코드리뷰 요청합니다.#37

Code

Merged

hongsii merged 28 commits intowoowacourse:jnsornwoowacourse/java-calculator:jnsornfrom jnsorn:onboardingjnsorn/java-calculator:onboardingCopy head branch name to clipboardFeb 10, 2020

+634-1

Commits

Commits on Feb 5, 2020

• [Add] split method

  kimevanjunseok

  committed
  2bb20b3

  Copy full SHA for 2bb20b3

• [Add] substring method

  kimevanjunseok

  committed
  e175d57

  Copy full SHA for e175d57

• [Add] charAt method with using assertThatThrownBy

  kimevanjunseok

  committed
  4923054

  Copy full SHA for 4923054

• [Refactor] add class information

  kimevanjunseok

  committed
  3b70d9f

  Copy full SHA for 3b70d9f

• [Docs] add README

  kimevanjunseok

  committed
  d7d14a9

  Copy full SHA for d7d14a9

• [Refactor] split test using containsExactly()

  kimevanjunseok

  committed
  f614840

  Copy full SHA for f614840

• [Docs] update README

  kimevanjunseok

  committed
  ba9a772

  Copy full SHA for ba9a772

• [Add] method to check size of Set

  kimevanjunseok

  committed
  00b743c

  Copy full SHA for 00b743c

• [Add] method to check if Set contains value using @ParameterizedTest

  kimevanjunseok

  committed
  4e97baa

  Copy full SHA for 4e97baa

• [Add] method to check if Set contains value in all cases

  kimevanjunseok

  committed
  370f685

  Copy full SHA for 370f685

• [Refactor] separate charAt method

  kimevanjunseok

  committed
  26c78d6

  Copy full SHA for 26c78d6

• [Docs] update README

  kimevanjunseok

  committed
  1a88b09

  Copy full SHA for 1a88b09

Commits on Feb 6, 2020

• [Docs] update README about calculator

  kimevanjunseok

  committed
  2f72d1c

  Copy full SHA for 2f72d1c

• [Add] function to get string from user

  kimevanjunseok

  committed
  64f7e39

  Copy full SHA for 64f7e39

• [Add] validation of input value

  kimevanjunseok

  committed
  090387b

  Copy full SHA for 090387b

• [Add] Test code about validation of input value

  kimevanjunseok

  committed
  3b65b88

  Copy full SHA for 3b65b88

• [Update] function to get string from user

  kimevanjunseok

  committed
  9bcabf0

  Copy full SHA for 9bcabf0

• [Add] function to calculate value

  kimevanjunseok

  committed
  ef2e8a0

  Copy full SHA for ef2e8a0

• [Add] Test code about function to calculate value

  kimevanjunseok

  committed
  787dec9

  Copy full SHA for 787dec9

• [Add] function to print result

  kimevanjunseok

  committed
  ffb2fb2

  Copy full SHA for ffb2fb2

Commits on Feb 7, 2020

• [Refactor] code separation

  kimevanjunseok

  committed
  6635bd2

  Copy full SHA for 6635bd2

• [Refactor] handle exception about divide

  kimevanjunseok

  committed
  1a87428

  Copy full SHA for 1a87428

• [Add] Test code about divide exception function

  kimevanjunseok

  committed
  7dc5b38

  Copy full SHA for 7dc5b38

Commits on Feb 9, 2020

• [Refactor] renaming of variables and method

  jnsorn

  committed
  3e96b56

  Copy full SHA for 3e96b56

• [Refactor] static variables, handle NPE

  jnsorn

  committed
  e790882

  Copy full SHA for e790882

• [Refactor] create Expression object after validation

  jnsorn

  committed
  07e22f0

  Copy full SHA for 07e22f0

• [Refactor] managing four operators as enum

  jnsorn

  committed
  1542a3a

  Copy full SHA for 1542a3a

• [Refactor] simple calculation logic using enum

  jnsorn

  committed
  6d63357

  Copy full SHA for 6d63357