Skip to content

Commit

Permalink
Merge pull request #4352 from wordpress-mobile/update/hide-help-butto…
Browse files Browse the repository at this point in the history
…n-from-ube

As described in #4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button isn't working as expected on iOS and prompts users to navigate away from the editor on Android, creating the potential for edits to be lost.

With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits.
  • Loading branch information
Siobhan Bamber committed Jan 14, 2022
2 parents c847b87 + 53b3cf3 commit e2c8aef
Show file tree
Hide file tree
Showing 15 changed files with 1,565 additions and 1,559 deletions.
2 changes: 1 addition & 1 deletion Gutenberg.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Pod::Spec.new do |s|
s.requires_arc = true
s.preserve_paths = 'bundle/ios/*'
s.swift_version = '5.0'
s.resources = ['gutenberg/packages/react-native-bridge/common/**/*.{js,css,json}', 'src/block-support/supported-blocks.json', 'resources/**/*.js']
s.resources = ['gutenberg/packages/react-native-bridge/common/**/*.{js,css,json}', 'src/block-support/supported-blocks.json', 'resources/**/*.{js,css}']

s.dependency 'React', react_native_version
s.dependency 'React-CoreModules', react_native_version
Expand Down
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Unreleased
---
* [*] Hide help button from Unsupported Block Editor. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4352/]
* [*] Add contrast checker to text-based blocks [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4357]

1.69.0
Expand Down
3,095 changes: 1,548 additions & 1,547 deletions bundle/ios/App.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/App.js.map

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion gutenberg
Submodule gutenberg updated 70 files
+2 −2 bin/api-docs/gen-theme-reference.js
+173 −0 changelog.txt
+5 −1 docs/contributors/code/release.md
+2 −0 docs/contributors/versions-in-wordpress.md
+19 −1 docs/manifest.json
+6 −0 docs/reference-guides/README.md
+1 −1 docs/reference-guides/core-blocks.md
+10 −0 docs/reference-guides/theme-json-reference/README.md
+5 −1 docs/reference-guides/theme-json-reference/theme-json-living.md
+63 −0 docs/reference-guides/theme-json-reference/theme-json-migrations.md
+117 −0 docs/reference-guides/theme-json-reference/theme-json-v1.md
+13 −1 docs/toc.json
+1 −1 gutenberg.php
+1 −1 lib/global-styles.php
+7 −21 package-lock.json
+1 −1 package.json
+8 −1 packages/block-editor/README.md
+8 −0 packages/block-editor/src/components/block-edit/index.js
+1 −1 packages/block-editor/src/components/border-radius-control/style.scss
+3 −7 packages/block-editor/src/components/iframe/index.js
+2 −2 packages/block-library/src/comment-date/index.php
+5 −5 packages/block-library/src/latest-comments/index.php
+9 −9 packages/block-library/src/latest-posts/index.php
+5 −1 packages/block-library/src/navigation/block.json
+6 −3 packages/block-library/src/navigation/style.scss
+1 −1 packages/block-library/src/post-author-name/index.php
+1 −1 packages/block-library/src/post-author/index.php
+7 −7 packages/block-library/src/post-comments-link/index.php
+2 −2 packages/block-library/src/post-date/index.php
+1 −1 packages/block-library/src/post-excerpt/index.php
+29 −19 packages/block-library/src/post-featured-image/edit.js
+1 −1 packages/block-library/src/post-featured-image/index.php
+3 −3 packages/block-library/src/post-navigation-link/index.php
+2 −2 packages/block-library/src/post-template/index.php
+1 −1 packages/block-library/src/post-terms/index.php
+1 −1 packages/block-library/src/post-title/index.php
+2 −2 packages/block-library/src/query/edit/index.js
+5 −9 packages/block-library/src/query/edit/inspector-controls/index.js
+41 −0 packages/block-library/src/query/edit/inspector-controls/order-control.js
+2 −0 packages/block-library/src/site-logo/index.js
+21 −0 packages/block-library/src/site-logo/transforms.js
+2 −0 packages/block-library/src/site-title/index.js
+21 −0 packages/block-library/src/site-title/transforms.js
+2 −0 packages/components/CHANGELOG.md
+1 −1 packages/components/src/box-control/styles/box-control-styles.js
+0 −1 packages/components/src/custom-gradient-picker/style.scss
+1 −1 packages/components/src/form-token-field/style.scss
+7 −6 packages/components/src/input-control/styles/input-control-styles.tsx
+2 −2 packages/components/src/select-control/README.md
+4 −2 packages/components/src/select-control/index.tsx
+1 −1 packages/components/src/select-control/stories/index.js
+0 −2 packages/components/src/tools-panel/styles.ts
+5 −2 packages/e2e-tests/specs/editor/blocks/classic.test.js
+18 −5 packages/e2e-tests/specs/editor/blocks/navigation.test.js
+0 −6 packages/e2e-tests/specs/editor/plugins/iframed-inline-styles.test.js
+0 −4 packages/e2e-tests/specs/editor/plugins/iframed-multiple-block-stylesheets.test.js
+66 −1 packages/e2e-tests/specs/editor/various/preview.test.js
+52 −5 packages/e2e-tests/specs/editor/various/reusable-blocks.test.js
+0 −20 packages/e2e-tests/specs/widgets/customizing-widgets.test.js
+0 −12 packages/e2e-tests/specs/widgets/editing-widgets.test.js
+53 −0 packages/edit-site/src/components/header/more-menu/copy-content-menu-item.js
+2 −0 packages/edit-site/src/components/header/more-menu/index.js
+57 −67 packages/edit-site/src/components/list/added-by.js
+6 −1 packages/editor/src/store/selectors.js
+8 −0 ...t-native-bridge/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/GutenbergWebViewActivity.java
+0 −8 packages/react-native-bridge/ios/GutenbergWebFallback/FallbackJavascriptInjection.swift
+8 −0 packages/react-native-bridge/ios/GutenbergWebFallback/GutenbergWebSingleBlockViewController.swift
+16 −1 packages/react-native-bridge/ios/SourceFile.swift
+2 −0 packages/react-native-editor/CHANGELOG.md
+1 −1 readme.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/* Remove \'help\' button from the editor. */
.a8c-faux-inline-help {
display: none;
}

0 comments on commit e2c8aef

Please sign in to comment.