Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide help button from UBE #4352

Merged
merged 40 commits into from
Jan 14, 2022
Merged

Hide help button from UBE #4352

merged 40 commits into from
Jan 14, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Dec 8, 2021 •
edited
Loading

Addresses #4339

Related PRs and Installable Builds

Description

As described in #4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button isn't working as expected on iOS and prompts users to navigate away from the editor on Android, creating the potential for edits to be lost.

With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits. A high-level overview of the code changes can be found in the Types of changes section of the Gutenberg PR.

Testing

Please refer to the Gutenberg PR as the "central PR" with the most up-to-date testing instructions.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB closed this Dec 8, 2021
@SiobhyB SiobhyB force-pushed the update/hide-help-button-from-ube branch from 239447d to 6924222 Compare December 8, 2021 12:09
@SiobhyB SiobhyB reopened this Dec 8, 2021
@SiobhyB SiobhyB mentioned this pull request Dec 8, 2021
Merged
7 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 8, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB self-assigned this Dec 8, 2021
@SiobhyB SiobhyB force-pushed the update/hide-help-button-from-ube branch from 8304586 to eeef532 Compare December 8, 2021 13:02
@SiobhyB SiobhyB requested a review from twstokes December 8, 2021 16:22
@SiobhyB SiobhyB marked this pull request as ready for review December 8, 2021 16:22
@SiobhyB SiobhyB force-pushed the update/hide-help-button-from-ube branch from 34e9298 to f93e8c8 Compare December 9, 2021 16:03
Siobhan added 4 commits December 9, 2021 16:10
Merge branch 'update/hide-help-button-from-ube' of https://github.com…
0f4408e 
…/wordpress-mobile/gutenberg-mobile into update/hide-help-button-from-ube
Revert .gitmodules change
72918fc
Hide help button via external-style-overrides.css
029faec 
With this commit, a new CSS file is created for external styles. The initial purpose behind this file is to hide the inline help button for WordPress.com users.
Update reference to Gutenberg
3568736
@SiobhyB SiobhyB force-pushed the update/hide-help-button-from-ube branch from b60c55a to 3568736 Compare December 9, 2021 16:49
@SiobhyB SiobhyB removed the request for review from twstokes December 10, 2021 09:56
Siobhan added 5 commits December 14, 2021 11:56
Merge branch 'develop' into update/hide-help-button-from-ube
99c5cd7
Bundle changes
9ba149c
Apply package-lock changes
8f8c2f9
Enable .css files to be referenced from resources folder in iOS
bcb75bd 
With this commit, the global pattern for the resources folder is updated to include .css files, so that they can be referenced from iOS.
Update release notes
748f72e
@SiobhyB SiobhyB mentioned this pull request Dec 14, 2021
Merged
4 tasks
twstokes
twstokes reviewed Dec 17, 2021
View reviewed changes
resources/unsupported-block-editor/external-style-overrides.css Show resolved Hide resolved
package.json Outdated
@@ -33,6 +33,7 @@
"eslint": "^6.8.0",
"eslint-plugin-eslint-comments": "3.1.2",
"eslint-plugin-import": "2.18.2",
"eslint-plugin-jest": "^25.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiobhyB is this dependency upgrade required for this feature? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, no, thanks for spotting that! I had some trouble getting tests to pass with this PR, so kept running npm install and this was a change that got committed as part of that. I've updated in 79e5caf.

@twstokes
Copy link
Contributor

Great work @SiobhyB! This is working well. 🙇 So far I've added some comments and questions to all the PRs but WPAndroid. Thank you.

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Dec 17, 2021

Thank you so much for the review so far @twstokes! 🙇‍♀️ I've gone ahead to respond to all of your comments now, looking forward to hearing any further thoughts.

I also wanted to note that the Check Correctness test keeps failing on this PR, which is the reason you'll see a lot of changes to the package-lock.json in the commit history. I'll make sure to clean the commit history and resolve any conflicts with package-lock.json before merging.

twstokes
twstokes approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @SiobhyB. 👍

@SiobhyB SiobhyB added this to the 1.70.0 (19.1) milestone Jan 14, 2022
@SiobhyB SiobhyB merged commit e2c8aef into develop Jan 14, 2022
@SiobhyB SiobhyB deleted the update/hide-help-button-from-ube branch January 14, 2022 14:04
@fluiddot fluiddot mentioned this pull request Jan 20, 2022
Merged
4 tasks
@SiobhyB SiobhyB mentioned this pull request May 3, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

Assignees

@SiobhyB SiobhyB

Labels
Unsupported Block Editor
Projects
None yet
Milestone
1.70.0 (19.1)
Development

Successfully merging this pull request may close these issues.
2 participants
@SiobhyB @twstokes