Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Entire Word Prevents Merging Blocks #2375

Open
mchowning opened this issue Jun 11, 2020 · 4 comments
Open

Deleting Entire Word Prevents Merging Blocks #2375

mchowning opened this issue Jun 11, 2020 · 4 comments

Comments

@mchowning
Copy link
Contributor

mchowning commented Jun 11, 2020

Describe the bug

On Android only, when two blocks are going to be merged, deleting a swiped word at the beginning of the second block prevents them from being merge-able.

To Reproduce

1. Deleting Swiped Word

  1. Type some words into a paragraph block
  2. Move the cursor somewhere to the middle of the text and tap Enter to split the block
  3. Add a word by swiping (also test tapping) (if you tap letters instead of swiping the bug does not occur. It occurs with tapping out words as well, but only if you select the entire word and then hit backspace)
  4. Delete that word by pressing backspace
  5. Press backspace to merge the blocks
  6. Observe that the blocks will not merge (nothing happens when you press backspace).

backspace_merge mp4

2. Deleting Selected Word

  1. Type some words into a paragraph block
  2. Tap Enter to create a second paragraph block
  3. Type some words into the second paragraph block
  4. Delete the first word in the second paragraph block by selecting it and pressing backspace
  5. Press backspace again to merge the blocks
  6. Observe that the blocks will not merge (nothing happens when you press backspace the second time).

backspace_split_merge mp4

Expected behavior

When two paragraph blocks exist next to each other, pressing backspace at the beginning of the second paragraph block should always merge the two blocks.

Smartphone (please complete the following information):

@mchowning mchowning changed the title Deleting Entire Words Prevents Merging Blocks Deleting Entire Word Prevents Merging Blocks Jun 11, 2020
@guarani
Copy link
Contributor

guarani commented Jul 20, 2020

I tested these two issues using WPAndroid 15.2.1 (I can confirm these are not present on iOS 15.3 beta).

Deleting Swiped Word issue

I could reproduce this using the Gboard keyboard. I also noticed it's not an issue on blocks that support line breaks, i.e. those where hitting backspace just merges lines, not blocks (which indicates this isn't the exact same issue as #2373).

Deleting Selected Word

I could reproduce this using by typing on the Gboard. I couldn't reproduce using the Samsung keyboard. Again, it's not an issue on blocks that support line breaks.

@AmandaRiu
Copy link
Contributor

Verified still an issue as of 1.57.0. Tested on a physical Android Pixel 4 running Android 11 w/ Gboard:

screencapture-1626124965067.mp4

@guarani
Copy link
Contributor

guarani commented Sep 17, 2021

Confirmed this is still an issue in WPAndroid 18.2-rc-3.

@illusaen
Copy link
Contributor

Quick update: when doing alpha writing flow tests for release 18.6 (1.65), swiping a word does still indeed break. However, it only breaks if you don't insert a space after the swiped word. If you do, it seems to recognize it fine.

@SiobhyB SiobhyB mentioned this issue Sep 5, 2022
4 tasks
@geriux geriux mentioned this issue Sep 6, 2022
4 tasks
@SiobhyB SiobhyB mentioned this issue Oct 4, 2022
4 tasks
@SiobhyB SiobhyB mentioned this issue Nov 2, 2022
4 tasks
@geriux geriux mentioned this issue Dec 20, 2022
4 tasks
@geriux geriux mentioned this issue Dec 27, 2022
4 tasks
@SiobhyB SiobhyB mentioned this issue Jan 11, 2023
4 tasks
@geriux geriux mentioned this issue Jan 13, 2023
4 tasks
@jhnstn jhnstn mentioned this issue Feb 8, 2023
4 tasks
@geriux geriux mentioned this issue Feb 21, 2023
4 tasks
@SiobhyB SiobhyB mentioned this issue Mar 21, 2023
4 tasks
@jhnstn jhnstn mentioned this issue Apr 5, 2023
4 tasks
@geriux geriux mentioned this issue Apr 25, 2023
4 tasks
@jhnstn jhnstn mentioned this issue May 3, 2023
4 tasks
@SiobhyB SiobhyB mentioned this issue May 16, 2023
4 tasks
@SiobhyB SiobhyB mentioned this issue Aug 8, 2023
4 tasks
@SiobhyB SiobhyB mentioned this issue Aug 17, 2023
4 tasks
@fluiddot fluiddot mentioned this issue Dec 5, 2023
4 tasks
@SiobhyB SiobhyB mentioned this issue Jan 23, 2024
4 tasks
@geriux geriux mentioned this issue Apr 30, 2024
4 tasks
@geriux geriux mentioned this issue Jun 4, 2024
4 tasks
This was referenced Jun 13, 2024
@geriux geriux mentioned this issue Jul 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants