Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.80.0 #5044

Merged
merged 8 commits into from
Jul 21, 2022
Merged

Release 1.80.0 #5044

merged 8 commits into from
Jul 21, 2022

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jul 21, 2022 •
edited
Loading

Release for Gutenberg Mobile 1.80.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1: Performance improvements for Gallery and Image block

Improves the performance of the Gallery and Image block, which should be especially noticeable on lower-end devices.

Change 2: Prevent validation error when viewing VideoPress markup within app

Partially addresses a long-standing problem where blocks with VideoPress markup create a validation error within the app. This will be noticeable for users with WP.com or Jetpack sites with VideoPress enabled who go between the web and app to save their content (containing videos).

Change 3: Inserter displays block collections

Enables additional organization of block "collections" within the inserter, similar to the web block inserter. One use case for this is grouping Jetpack blocks under one heading for WP.com and Jetpack sites, which was introduced in Automattic/jetpack#25092.

Change 4: Add React Native FastImage

Adds the React Native FastImage library and improves the performance of image rendering in the editor.

Change 5: Fix incorrect spacing within Image alt text footnote

Fixes a small bug to add a space between the two sentences of the alt text footnote (found in the Image block).

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Jul 21, 2022
Merged
Merged
Merged
@SiobhyB SiobhyB requested a review from geriux July 21, 2022 10:17
@SiobhyB SiobhyB marked this pull request as ready for review July 21, 2022 10:20
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 21, 2022 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: pr19089-9e4ca70
Device: iPhone XR

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 21, 2022 •
edited
Loading

🟢 Smoke testing and new changes (iOS)

Build: pr19089-9e4ca70
Device: iPhone XR

Smoke testing

  • Verify editor doesn't crash

New changes

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 21, 2022 •
edited
Loading

🟢 Smoke testing (Android)

Build: wordpress-installable-build-pr16931-128fe7c.apk,
Device: Pixel 6

  • Verify editor doesn't crash

geriux
geriux approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@SiobhyB SiobhyB enabled auto-merge July 21, 2022 13:37
@SiobhyB SiobhyB merged commit 63d2cd3 into trunk Jul 21, 2022
@SiobhyB SiobhyB deleted the release/1.80.0 branch July 21, 2022 14:05
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 26, 2022 •
edited
Loading

🟢 Writing Flow checklist (Android)

Build: 20.4-rc-1
Device: Pixel 6

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 26, 2022 •
edited
Loading

🟢 New changes (Android)

Build: 20.4-rc-1
Device: Pixel 6

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jul 26, 2022 •
edited
Loading

🟢 Test Suite 5 (Android)

Build: 20.4-rc-1
Device: Pixel 6

Video block - 1

  • Video block - Insert video from device (failing) - steps
  • Video block - Close/Re-open post with an ongoing video upload - steps

Video block - 2

  • Video block - Insert video from device (cancel) - steps
  • Video block - Close post with an ongoing video upload - steps
  • Video block - Add Caption - steps

File block - 1

  • File block - Upload completes successfully from the device library - steps
  • File block - Insert completes successfully from the WordPress Media library - steps
  • File block - Upload fails from the device library - steps
  • File block - Stop the file upload before it completes - steps

File block - 2

  • File block - Close the post with an ongoing file upload - steps
  • File block - Replace the selected files - steps
  • File block - Change the alignment in the File Block - steps
  • File block - The Link To Block Setting should open - steps

File block - 3

  • File block - Open link in new tab - steps
  • File block - Show/hide download button (Block Settings only) - steps
  • File block - Copy file URL - steps
  • File block - Close/Re-open post with an ongoing file upload - steps

Audio block - 1

  • Audio block - Upload completes successfully from the device library - steps
  • Audio block - Insert completes successfully from the WordPress Media library - steps

Audio block - 2

  • Audio block - Upload fails from the device library - steps
  • Audio block - Stop the audio file upload before it completes - steps

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - steps
  • Audio block - Replace the selected files - steps
  • Audio block - Change the alignment in the Audio Block - steps

Audio block - 4

  • Audio block - Autoplay setting - steps
  • Audio block - Loop setting - steps
  • Audio block - Close/Re-open post with an ongoing audio file upload - steps

Reusable block - 1

  • Reusable block - Add block - steps
  • Reusable block - Convert to regular blocks - steps

Reusable block - 2

  • Reusable block - Deleted reusable block - steps
  • Reusable block - Recursive block rendering - steps

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - steps

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - steps

@dcalhoun
Copy link
Member

dcalhoun commented Jul 26, 2022 •
edited
Loading

🔴 Writing Flow checklist (iOS)

Build: 20.4.0.0
Device: iPhone SE (iOS 15.6)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading

Splitting and merging

  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Jul 26, 2022 •
edited
Loading

🟢 New changes (iOS)

Build: 20.4.0.0
Device: iPhone SE (iOS 15.6)

@dcalhoun
Copy link
Member

dcalhoun commented Jul 26, 2022 •
edited
Loading

🟢 Test Suite 1 (iOS)

Build: 20.4.0.0
Device: iPhone SE (iOS 15.6)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiobhyB @dcalhoun @geriux