Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.87.1 #5394

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Release 1.87.1 #5394

merged 8 commits into from
Jan 13, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jan 13, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.87.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Remove unnecessary negative margin around empty gallery block

RichText - Parse CSS values and avoid setting undefined ones

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Jan 13, 2023
Merged
Merged
Merged
@geriux geriux marked this pull request as ready for review January 13, 2023 13:09
@SiobhyB SiobhyB self-requested a review January 13, 2023 13:44
@SiobhyB
Copy link
Contributor

SiobhyB commented Jan 13, 2023 •
edited
Loading

🟢 New changes (iOS)

Build: pr19911-453eea6 from wordpress-mobile/WordPress-iOS#19911
Device: iPhone XR, iOS 16.2

@geriux
Copy link
Contributor Author

geriux commented Jan 13, 2023

🟢 New changes (Android)

Build: pr17757-09514d8.apk
Device: Redmi Note 8T (OS11)

  • Remove unnecessary negative margin around empty gallery block
  • RichText - Parse CSS values and avoid setting undefined ones

@geriux
Copy link
Contributor Author

geriux commented Jan 13, 2023 •
edited
Loading

🟢 Writing Flow checklist (Android)

Build: pr17757-09514d8.apk
Device: Redmi Note 8T (OS11)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor

SiobhyB commented Jan 13, 2023 •
edited
Loading

🟢 Writing flow checklist (iOS)

Build: pr19911-453eea6 from wordpress-mobile/WordPress-iOS#19911
Device: iPhone XR, iOS 16.2]

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

SiobhyB
SiobhyB approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#47143 (review)

@geriux geriux merged commit 3953852 into trunk Jan 13, 2023
@geriux geriux deleted the release/1.87.1 branch January 13, 2023 18:00
@geriux
Copy link
Contributor Author

geriux commented Jan 17, 2023

🟢 New changes (iOS)

Build: 21.5.0.1 (Testflight)
Device: iPhone 14 Pro

@fluiddot fluiddot mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @SiobhyB