Remove unneeded and deprecated methods/actions #586
Conversation
| require_relative '../../helper/ios/ios_version_helper' | ||
| require_relative '../../helper/android/android_version_helper' |
There was a problem hiding this comment.
These version helpers are not being used in this action.
| require_relative '../../helper/ios/ios_version_helper' | ||
| require_relative '../../helper/android/android_version_helper' |
There was a problem hiding this comment.
These version helpers are not being used in this action.
| require_relative '../../helper/ios/ios_version_helper' | ||
| require_relative '../../helper/android/android_version_helper' |
There was a problem hiding this comment.
This version helper is not being used in this action.
There was a problem hiding this comment.
A bit strange that this action is in common/ yet use ios_version_helper (to call Fastlane::Helper::Ios::VersionHelper.calc_next_release_version(last_stone[:title]))…
I mean, in practice I guess it doesn't matter because the computation for the next_release_version is the same for iOS and Android, which is why we ended up using an arbitrary one I guess, but still the unbalance feels a bit strange.
Not really a problem for this PR, and I'm guessing we'll plan to deprecate this action in a few months once everything have migrated to ReleaseV2 and that ReleaseV2 will be the one creating the new milestones instead of Fastlane… so not worth fixing anyway 🙃
| require_relative '../../helper/ios/ios_version_helper' | ||
|
|
There was a problem hiding this comment.
This version helper is not being used in this action.
Generated by 🚫 Danger |
There was a problem hiding this comment.
You can see this method in the WooCommerce iOS Fastfile for an example of how to use the Versioning module methods to check for a hotfix: https://github.com/woocommerce/woocommerce-ios/blob/dcfbf67c24fec624bd1935a465aeff373a0aaf01/fastlane/Fastfile#L1391
There was a problem hiding this comment.
Similar to Android in https://github.com/wordpress-mobile/release-toolkit/pull/580/files, the ios_tag_build action is not being used by any of the Automattic apps in lieu of using the GitHub release system to tag builds.
There was a problem hiding this comment.
This action is not being used by any of the Automattic apps, so I decided to delete it so that the get_public_version method could be removed.
| @@ -1,46 +0,0 @@ | |||
| module Fastlane | |||
| module Actions | |||
| class IosValidateCiBuildAction < Action | |||
There was a problem hiding this comment.
I wasn't even aware we had such an action to begin with 😅
mokagio
merged commit 64f8db3
into
mokagio/breaking-remove-deprecated-actions
What does it do?
This PR builds on Gio's #580 to remove some additional unneeded or deprecated methods and actions for the 12.0 release. The versioning methods and actions have been replaced by the methods in the
Versioningmodule.Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.