-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded and deprecated methods/actions #586
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ | |
require 'date' | ||
require_relative '../../helper/github_helper' | ||
require_relative '../../helper/ios/ios_version_helper' | ||
require_relative '../../helper/android/android_version_helper' | ||
Comment on lines
4
to
-5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This version helper is not being used in this action. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A bit strange that this action is in Not really a problem for this PR, and I'm guessing we'll plan to deprecate this action in a few months once everything have migrated to ReleaseV2 and that ReleaseV2 will be the one creating the new milestones instead of |
||
module Fastlane | ||
module Actions | ||
class CreateNewMilestoneAction < Action | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
require 'fastlane/action' | ||
require 'date' | ||
require_relative '../../helper/github_helper' | ||
require_relative '../../helper/ios/ios_version_helper' | ||
require_relative '../../helper/android/android_version_helper' | ||
Comment on lines
-4
to
-5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These version helpers are not being used in this action. |
||
module Fastlane | ||
module Actions | ||
class CreateReleaseAction < Action | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,6 @@ class IosCheckBetaDepsAction < Action | |
NON_STABLE_PODS_MESSAGE = "Please create a new stable version of those pods and update the Podfile to the newly released version before continuing with the code freeze:\n".freeze | ||
|
||
def self.run(params) | ||
require_relative '../../helper/ios/ios_version_helper' | ||
|
||
Comment on lines
-10
to
-11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This version helper is not being used in this action. |
||
yaml = YAML.load_file(params[:lockfile]) | ||
non_stable_pods = {} # Key will be pod name, value will be reason for flagging | ||
|
||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These version helpers are not being used in this action.