Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded and deprecated methods/actions #586

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- Removed `build_gradle_path` parameter from `android_current_branch_is_hotfix` [#579]
- Deleted `Fastlane::Helper::Android::GitHelper` and `Fastlane::Helper::Ios::GitHelper` [#579]
- Deleted the following deprecated actions: [#577, #579]
- Deleted the following deprecated actions: [#577, #579, #586]
- `android_betabuild_prechecks`
- `android_build_prechecks`
- `android_bump_version_beta`
Expand All @@ -30,8 +30,14 @@
- `ios_bump_version_release`
- `ios_codefreeze_prechecks`
- `ios_completecodefreeze_prechecks`
- `ios_current_branch_is_hotfix`
- `ios_finalize_prechecks`
- `ios_get_app_version`
- `ios_get_build_number`
- `ios_get_build_version`
- `ios_hotfix_prechecks`
- `ios_tag_build`
- `ios_validate_ci_build`

### New Features

Expand Down
2 changes: 1 addition & 1 deletion MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- `android_current_branch_is_hotfix` no longer supports the `build_gradle_path` parameter. Convert the project to define `versionName` and `versionCode` in `version.properties` and call `android_current_branch_is_hotfix` with `version_properties_path`.
- Various helper methods and actions to calculate version bumps have been deleted (see `CHANGELOG.md` for the full list). Use the `Versioning` module for any version computation or automation.
- `Fastlane::Helper:Android::GitHelper` and `Fastlane::Helper::Ios::GitHelper` have been removed. If you were using their respective `commit_version_bump` methods, you'll need to run the commit directly in your `Fastfile`, for example via Fastlane's `git_commit` action.
- `android_tag_build` has been removed. Our recommended workflow for tagging releases relies on GitHub creating a tag when a GitHub release is published.
- `android_tag_build` and `ios_tag_build` have been removed. Our recommended workflow for tagging releases relies on GitHub creating a tag when a GitHub release is published.

## From `10.0.0` to `11.0.0`

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
require 'fastlane/action'
require 'date'
require_relative '../../helper/github_helper'
require_relative '../../helper/ios/ios_version_helper'
require_relative '../../helper/android/android_version_helper'
Comment on lines -4 to -5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These version helpers are not being used in this action.

module Fastlane
module Actions
class CloseMilestoneAction < Action
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
require 'date'
require_relative '../../helper/github_helper'
require_relative '../../helper/ios/ios_version_helper'
require_relative '../../helper/android/android_version_helper'
Comment on lines 4 to -5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version helper is not being used in this action.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit strange that this action is in common/ yet use ios_version_helper (to call Fastlane::Helper::Ios::VersionHelper.calc_next_release_version(last_stone[:title]))…
I mean, in practice I guess it doesn't matter because the computation for the next_release_version is the same for iOS and Android, which is why we ended up using an arbitrary one I guess, but still the unbalance feels a bit strange.

Not really a problem for this PR, and I'm guessing we'll plan to deprecate this action in a few months once everything have migrated to ReleaseV2 and that ReleaseV2 will be the one creating the new milestones instead of Fastlane… so not worth fixing anyway 🙃

module Fastlane
module Actions
class CreateNewMilestoneAction < Action
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
require 'fastlane/action'
require 'date'
require_relative '../../helper/github_helper'
require_relative '../../helper/ios/ios_version_helper'
require_relative '../../helper/android/android_version_helper'
Comment on lines -4 to -5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These version helpers are not being used in this action.

module Fastlane
module Actions
class CreateReleaseAction < Action
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ class IosCheckBetaDepsAction < Action
NON_STABLE_PODS_MESSAGE = "Please create a new stable version of those pods and update the Podfile to the newly released version before continuing with the code freeze:\n".freeze

def self.run(params)
require_relative '../../helper/ios/ios_version_helper'

Comment on lines -10 to -11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version helper is not being used in this action.

yaml = YAML.load_file(params[:lockfile])
non_stable_pods = {} # Key will be pod name, value will be reason for flagging

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

44 changes: 0 additions & 44 deletions lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_tag_build.rb

This file was deleted.

This file was deleted.

Loading
Loading