Executors are now Observable #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... but the connections to the simulation environment run much deeper.
Updated the executors accordingly: MultiStateExecutor AkkaExecutor MongoExecutor Also fixed MultiStateExecutor not retrieving process instances correctly. However, it is still failing the unit tests.
This is work in progress - code is broken AkkaExecutor is now complying, but there is more to do and the tests are broken. See issue #5 for more information
We need the notion of a FutureExecutor for this one.
Added X separates this from older implementation until we have finished editing all previous references. Improved typing of PiEventHandlerFactory.
Now working on the unit tests. We don't really need a separate FutureExecutor. We can include the corresponding method in ProcessExecutor just fine!
MultiStateExecutor still fails sometimes - some unresolved race conditions probably.
The "run" method returns the ID after it tries some initial calculations. This means that events may be published before the promise executor has had a chance to subscribe. e.g. exceptions thrown during "run" will not be caught
Fixed all the errors in the simulation code (mainly due to references to FutureExecutor).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partially addressing #5
Executors must now implement (or mixin) a PiObservable interface. Multi-actor executors (like AkkaExecutor and KafkaExecutor) must rely on some sort of Event Stream.
Executors must also publish appropriate PiEvents (see WorkflowFM-PEW/src/com/workflowfm/pew/PiEventHandler.scala) when they happen.
Finally there is a change in the ProcessExecutor interface to enable the management of such listeners. Executors must now implement 2 methods,
initandstart(see WorkflowFM-PEW/src/com/workflowfm/pew/execution/ProcessExecutor.scala).The currently included executors have all been updated to reflect these changes.