chore: configure PHPStan static analysis

[justlevine]

This PR sets up PHPStan linting for the project.

No CI is currently included, since the plugin fails even scanning at Level 0, but in light of the results of the phpcs audit, I think it makes sense to already include it since you gotta start somewhere.

Follow-up PRs will address actual code issues unearthed by these lints.

To test,

1. run composer install
2. run composer phpstan.
3. copy phpstan.neon.dist to phpstan.neon, and change the parameters.level to 8.
4. rerun composer phpstan

Additional notes

Once you're ready to add a .distignore file or a composer archive property to this project, the phpstan.neon.dist file and /phpstan directory should be excluded.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 974bc5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[justlevine]

Until this is merged/rejected, Ill be tracking error level => fixes in this comment

• Level 0
  • fix: [PHPStan] actions should return void #88
• Level 1
  • fix: restore missing __() in admin notice #89
  • fix: [PHPStan] $block_attributes is always set #90
  • dev: [PHPStan] remove unused $type_registry from resolveType callbacks #92
  • The remaining two issuesat this level (missing $default param in DOMHelpers::getTextFromSelector(), and the unnecessary constant ) need more information before I can resolve.
• Level 2
  • chore: [PHPStan] add missing \ to docblock types #93
  • fix: [PHPStan] bad return type for WPHelpers::get_supported_post_types() #94
  • The invalid WPGraphQL\ContentBlocks\Utilities\default error is fixed by chore: address phpcs issues #85
• Level 3
  • When the above PRs are applied, no PHPStan level 3 errors exist.
• Level 4
  • fix: cleanup unnecessary conditionals #95
  • The remaining error concerns checking properties on a DiDom Document object. I'm not familiar enough with the class to know the best way to resolve this.
• Level 5
  • fix: bad conditional check for empty $html in DOMHelpers::parseFirstNodeAttribute() #96
• Level 6
  • chore: [PHPStan] add missing return types #99
  • fix: [PHPStan] WPGraphQLHelpers::format_type_name() handling #100
  • The remaining issues at this level regard missing return types for Block::resolve() (a string Im guessing, but im not sure what purpose this method serves like this instead of a callable, so I didnt investigate), and Block::resolve_block_attributes(), ( I'm not entire sure what all the possible return types are, and didnt want to introduce another mixed into the codebase).
• Level 7
  • The are additional DiDom usage errors that I'm not familiar enough to resolve without feedback.
• Level 8
  • fix: [PHPStan] better type checking in ContentBlocksResolver::resolve_content_blocks() #101
  • fix: [PHPStan] better type checking in Block.php methods #102

(Level 9 addresses the use of mixed, and doesn't really add value when working in WordPress.)

[justlevine]

I've completed my audit: There are 9 remaining issues once the above PRs are merged.