fix: [PHPStan] $block_attributes is always set
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 99ac818 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlevine
commented
May 19, 2023
| $graphql_type = null; | ||
|
|
||
| if ( ! isset( $attribute_config['type'] ) ) { | ||
| return $block_attribute_fields; |
There was a problem hiding this comment.
Should this really be returning? My limited understanding of the code is that we want to continue.
Beyond the scope of this PR, but I didnt know a better way to flag it.
There was a problem hiding this comment.
we want to
continue
I think you're right.
mindctrl
previously approved these changes
May 22, 2023
mindctrl
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in
Block::get_block_attributes_field(), where the method was incorrectly checking if the paramater$block_attributeswas passed to the method (isset()) instead of if the value passed wasnull.The param signature has also been fixed and moved into PHP, to prevent errors like this from going unnoticed in the future.
Caught by PHPStan level 1.