-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change internal flag organization in CMake build to not be global #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islas
force-pushed
the
cmake-restructureFlags
branch
from
August 6, 2024 02:30
e909e57
to
6b9d27e
Compare
Requires #2056 |
This was referenced Aug 6, 2024
Merged
This was referenced Aug 6, 2024
Open
Open
amstokely
previously approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuring compilation settings at the target level instead of the global level is an excellent decision and will definitely improve the maintainability of the CMake build. I approve these changes.
mgduda
previously approved these changes
Oct 12, 2024
…o cmake-restructureFlags
mgduda
approved these changes
Oct 14, 2024
amstokely
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: cmake, flags, compilation
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The current iteration of the cmake build places all configuration flags in the global properties of the project. While this works when just building WRF, integration with other projects' cmake builds if placed under WRF pollutes their respective build flags.
Solution:
Adjust the layout of the flags to instead carry them in a variable, and prefer using
target_*
calls for flag usage.LIST OF MODIFIED FILES:
M CMakeLists.txt
M chem/CMakeLists.txt
M external/CMakeLists.txt
M external/io_adios2/CMakeLists.txt
M external/io_netcdf/CMakeLists.txt
M external/io_netcdfpar/CMakeLists.txt
M external/io_pnetcdf/CMakeLists.txt
M frame/CMakeLists.txt
M main/CMakeLists.txt
M phys/CMakeLists.txt
M tools/CMakeLists.txt
RELEASE NOTE:
Change internal flag organization in CMake build to not be global