CMake confcheck switch to try_* functions #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2024
Open
amstokely
previously approved these changes
Sep 23, 2024
islas
force-pushed
the
cmake-confcheck-try_funcs
branch
from
812acda to
fe15edf
Compare
amstokely
approved these changes
Dec 16, 2024
mgduda
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: cmake, configuration
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The configuration checks done by the CMake build use language-specific calls between various functions. This has lead to a rather complex signature that is also limited in scope.
Solution:
Simplify the
wrf_conf_checkcalls to make use of CMake's built-intry_compile()andtry_run()functions, forwarding argument to those as necessary. Aside from minor adjustments to thewrf_conf_checkcalls this should appear as a drop-in replacement that provides the same results as before, i.e. no change to the system configuration options detected.