Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error ordering for traces #1398

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: error ordering for traces #1398

wants to merge 2 commits into from
+1,126 −1,114

Conversation

thisisnithin
Copy link
Member

Motivation and Context

Show error count and rate serparately and order by correctly.

Checklist

StarpTech
StarpTech requested changes Nov 25, 2024
View reviewed changes
controlplane/src/core/repositories/analytics/AnalyticsRequestViewRepository.ts
title: 'Errors',
},
errorRate: {
title: 'Error Rate%',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Rate % or Error Rate in % but Rate% looks a like typo 😄

@StarpTech
Copy link
Contributor

Could you elaborate a bit on what was wrong and how you fixed it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
connect controlplane protocol studio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisnithin @StarpTech