NEX-101: Sitemap.xml improvements #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate sitemaps for each locale in parallel rather than sequentially - Fetch each page in parallel rather than sequentially (except for the first page for each locale, as we need that to know how many pages to fetch) - Improved error messages if GET_SITEMAP_NODES graphql request fails
vermario
approved these changes
Jul 30, 2024
jekku123
pushed a commit
that referenced
this pull request
Oct 20, 2024
NEX-101: Sitemap.xml improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar idea and ticket as #236 but specifically for the sitemap. Decided to do this in a separate PR to keep things a bit more manageable. That one should be merged first, and then the diff for this PR will become smaller without the unrelated changes.
Link to ticket:
https://wunder.atlassian.net/browse/NEX-101 (ticket is about improving data fetching and error handling in general)
Link to feature environment:
https://feature-nex-101-sitemap-next.next-drupal-starterkit.dev.wdr.io/sitemap.xml
Changes proposed in this PR:
How to test: