NEX-172: Fix preview of previous revisions of nodes #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermario
commented
Sep 27, 2024
Comment on lines
-194
to
+195
| const [nodeId, revisionId] = previewData.resourceVersion.split(":"); | ||
| const path = `/node/${nodeId}/revisions/${revisionId}/view`; | ||
| const [_, revisionId] = previewData.resourceVersion.split(":"); | ||
| const path = `/node/${node.id}/revisions/${revisionId}/view`; |
There was a problem hiding this comment.
the resourceVersion property looks like this:
"id:20" for a revision with id 20.
So the existing code was just wrong :)
jekku123
pushed a commit
that referenced
this pull request
Oct 20, 2024
NEX-172: Fix preview of previous revisions of nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket:
https://wunder.atlassian.net/browse/NEX-172
Changes proposed in this PR:
We were not correctly passing the node id when doing the graphql query to get the entity at a certain revision. This PR fixes that.
How to test: