NEX-175: Add the possibility of running npx commands in lando #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermario
commented
Oct 18, 2024
| @@ -154,6 +158,8 @@ services: | |||
| # We instruct node to use the Lando CA certificate for HTTPS connections: | |||
| NODE_EXTRA_CA_CERTS: /lando/certs/LandoCA.crt | |||
| build: | |||
| # This is needed to be able to run lando npx commands: | |||
| - "mkdir -p /var/www/.npm-global/lib" | |||
There was a problem hiding this comment.
for the nodeuser inside the docker container /var/www is the home folder, the directory needs to be there for npx to work, apparently.
There was a problem hiding this comment.
tooling:
npx:
service: nodedoesn't work?
There was a problem hiding this comment.
Seems to work both ways.
Lets add
dir: /app/nextthere too.
There was a problem hiding this comment.
There was a problem hiding this comment.
I suggest installing npm globally instead. This would be a cleaner solution:
services:
node:
type: node:20
globals:
npm: latestThere was a problem hiding this comment.
nice! I tested it and it works, let's switch to that.
Committed in faefbac
jekku123
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the npx command to lando.
To test:
git clean -d -f./setup-lando.sh -clando npx shadcn@latest add badge