Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-log: Create stderr explicitly #1756

Merged
merged 1 commit into from
Jul 9, 2021
Merged

airframe-log: Create stderr explicitly #1756

merged 1 commit into from
Jul 9, 2021

Conversation

xerial
Copy link
Member

@xerial xerial commented Jul 9, 2021

This is for compatibility with Trino. Adding an option to redirect log messages to the current logger can be another option.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #1756 (6b9cdaa) into master (0007f44) will increase coverage by 1.45%.
The diff coverage is 78.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1756      +/-   ##
==========================================
+ Coverage   81.45%   82.91%   +1.45%     
==========================================
  Files         234      308      +74     
  Lines        9131    11903    +2772     
  Branches      626      763     +137     
==========================================
+ Hits         7438     9869    +2431     
- Misses       1693     2034     +341     
Impacted Files Coverage Δ
.../src/main/scala/wvlet/airframe/canvas/Memory.scala 100.00% <ø> (ø)
.../main/scala/wvlet/airframe/canvas/UnsafeUtil.scala 77.77% <ø> (ø)
...ain/scala/wvlet/airframe/codec/JavaTimeCodec.scala 100.00% <ø> (+3.33%) ⬆️
...src/main/scala/wvlet/airframe/codec/DataType.scala 95.00% <ø> (-1.16%) ⬇️
...in/scala/wvlet/airframe/codec/MessageContext.scala 75.36% <ø> (ø)
.../wvlet/airframe/control/CommandLineTokenizer.scala 80.00% <ø> (ø)
...src/main/scala/wvlet/airframe/control/OSType.scala 50.00% <ø> (ø)
...cala/wvlet/airframe/control/parallel/package.scala 100.00% <ø> (ø)
...rc/main/scala/wvlet/airframe/control/Control.scala 100.00% <ø> (ø)
...src/main/scala/wvlet/airframe/control/Ticker.scala 0.00% <0.00%> (ø)
... and 379 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90b901...6b9cdaa. Read the comment docs.

@xerial xerial merged commit 3c5eed4 into master Jul 9, 2021
@exoego exoego deleted the fix-logger-init branch February 4, 2022 02:21
xerial added a commit that referenced this pull request Mar 9, 2023
…btn (#2780)

Previously, airframe-log added a workaround for #1756, but it caused
`sbtn` not to show any log output.

By disabling the logging initialization in airlift log-manager, we no
longer need this workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant