Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airframe-log: Fixes #2777 Use the default System.err for supporting sbtn #2780

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

xerial
Copy link
Member

@xerial xerial commented Mar 9, 2023

Previously, airframe-log added a workaround for #1756, but it caused sbtn not to show any log output.

By disabling the logging initialization in airlift log-manager, we no longer need this workaround.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2780 (ba03ab0) into master (e83252e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2780   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         337      337           
  Lines       14176    14176           
  Branches     2340     2299   -41     
=======================================
  Hits        11663    11663           
  Misses       2513     2513           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83252e...ba03ab0. Read the comment docs.

@xerial xerial merged commit 13c27fc into master Mar 9, 2023
@xerial xerial deleted the logoutput branch March 9, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant