surface: Fix #3454 - methods in generic classes - for Scala 3 #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndrejSpanel
added a commit
to OndrejSpanel/airframe
that referenced
this pull request
Mar 22, 2024
OndrejSpanel
added a commit
to OndrejSpanel/airframe
that referenced
this pull request
Mar 22, 2024
xerial
changed the title
|
As we don't need to support everything for Scala 2 as well, we can put the test case under src/test/scala-3 folder to pass the CI |
OndrejSpanel
force-pushed
the
generic-class-failure
branch
from
8bd98a0
to
4892f2e
Compare
|
Rebased, test moved to Scala 3. Should be ready to go. |
OndrejSpanel
force-pushed
the
generic-class-failure
branch
from
4892f2e
to
9f862f2
Compare
OndrejSpanel
force-pushed
the
generic-class-failure
branch
from
9f862f2
to
000907c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a test and Scala 3 fix of #3454. The major part of the fix is a simplification of
typeMappingTablefunction. I am not 100% sure what the previous implementation usingmethod.paramSymsswas trying to do, I only hope whatever it was, it had tests in place for that.@xerial The new test fails on Scala 2 - if you or anyone is interested in completing the fix, feel free to continue.