allow microphone and camera through iframe #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoushke
force-pushed
the
akoushke-patch-1
branch
from
73520f0
to
e4026ad
Compare
askmrsinh
requested changes
Sep 19, 2023
| @@ -609,7 +609,7 @@ | |||
| </div> | |||
| {:else} | |||
| <div id="iframe-url" class="tile is-child box is-translucent-black has-text-white is-flex-grow-1"> | |||
| <Iframe url={demo?.iframeUrl} /> | |||
| <Iframe url={demo?.iframeUrl} allow={'camera;microphone; fullscreen;display-capture'} /> | |||
There was a problem hiding this comment.
We should have a config setting in the builder form to explicitly allow such access. Not all iframes need it so it's not wise to expose it unnecessarily. In most cases, we or the end user may not have much control over what's loaded in the iframe and it could become an issue if such privileged access is granted for all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.