Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow microphone and camera through iframe #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow microphone and camera through iframe #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Iframe/Iframe.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<script lang="ts">
export let url = undefined;
export let ratio = 'is-5by4';
export let allow: string;
</script>

<figure class="image {ratio}">
<iframe src={url} class="has-ratio" />
<iframe title="iframe" src={url} class="has-ratio" {allow} />
</figure>

<style>
Expand Down
2 changes: 1 addition & 1 deletion src/routes/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@
</div>
{:else}
<div id="iframe-url" class="tile is-child box is-translucent-black has-text-white is-flex-grow-1">
<Iframe url={demo?.iframeUrl} />
<Iframe url={demo?.iframeUrl} allow={'camera;microphone; fullscreen;display-capture'} />
Copy link
Member

@askmrsinh askmrsinh Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a config setting in the builder form to explicitly allow such access. Not all iframes need it so it's not wise to expose it unnecessarily. In most cases, we or the end user may not have much control over what's loaded in the iframe and it could become an issue if such privileged access is granted for all.

</div>
{/if}
</div>
Expand Down