Skip to content

Commit

Permalink
Revert Uglifier to 4.1.18, due to bug in Uglify 3.4.9. (#1748)
Browse files Browse the repository at this point in the history
# Release Notes

Tech task: Revert Uglifier to 4.1.18, due to bug in Uglify 3.4.9

# Additional Context

mishoo/UglifyJS#3245 documents a bug which occurs when using compression.

There does not appear to be any way to disable this particular path through the uglifier.
  • Loading branch information
rdunlop authored and jhanggi committed Nov 5, 2018
1 parent d6800dc commit b9df8dc
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ gem "paranoia"
## views
gem "sass-rails"
gem "coffee-rails"
gem "uglifier"
gem "uglifier", "= 4.1.18" # 4.1.19 has an issue https://github.com/mishoo/UglifyJS2/issues/3245
gem "therubyracer"
gem "bootstrap-sass", "~> 2.3.2" # will not upgrade
gem "haml"
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ GEM
ttfunk (1.5.1)
tzinfo (1.2.5)
thread_safe (~> 0.1)
uglifier (4.1.19)
uglifier (4.1.18)
execjs (>= 0.3.0, < 3)
unicode-display_width (1.4.0)
unicorn (5.4.1)
Expand Down Expand Up @@ -737,7 +737,7 @@ DEPENDENCIES
text_helpers
therubyracer
thin
uglifier
uglifier (= 4.1.18)
unicorn
vuejs-rails (~> 1.0.26)
web-console
Expand Down
6 changes: 6 additions & 0 deletions config/initializers/uglifier_restriction.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# frozen_string_literal: true

unless Uglifier::VERSION == "4.1.18"
raise "Uglifier 4.1.19 has a bug (https://github.com/mishoo/UglifyJS2/issues/3245).
Please ensure it's fixed before advancing"
end

0 comments on commit b9df8dc

Please sign in to comment.