Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Uglifier to 4.1.18, due to bug in Uglify 3.4.9. #1748

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

rdunlop
Copy link
Contributor

@rdunlop rdunlop commented Nov 1, 2018

mishoo/UglifyJS#3245 documents
a bug which occurs when using compression.

There does not appear to be any way to disable this particular path through the uglifier.

mishoo/UglifyJS#3245 documents
a bug which occurs when using compression.

There does not appear to be any way to disable this particular path through the uglifier.
Copy link
Contributor

@jhanggi jhanggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there should there be a change to the Gemfile that restricts this. That seems easier to deal with that the initializer.

@jhanggi jhanggi merged commit b9df8dc into master Nov 5, 2018
@jhanggi jhanggi deleted the revert_uglifier branch November 5, 2018 20:11
ColinMcNeil pushed a commit to SquaredLabs/nucore-uconn that referenced this pull request Nov 9, 2018
# Release Notes

Tech task: Revert Uglifier to 4.1.18, due to bug in Uglify 3.4.9

# Additional Context

mishoo/UglifyJS#3245 documents a bug which occurs when using compression.

There does not appear to be any way to disable this particular path through the uglifier.
joshea0 pushed a commit to SquaredLabs/nucore-uconn that referenced this pull request Jan 16, 2019
# Release Notes

Tech task: Revert Uglifier to 4.1.18, due to bug in Uglify 3.4.9

# Additional Context

mishoo/UglifyJS#3245 documents a bug which occurs when using compression.

There does not appear to be any way to disable this particular path through the uglifier.
joshea0 pushed a commit to SquaredLabs/nucore-uconn that referenced this pull request Jan 16, 2019
# Release Notes

Tech task: Revert Uglifier to 4.1.18, due to bug in Uglify 3.4.9

# Additional Context

mishoo/UglifyJS#3245 documents a bug which occurs when using compression.

There does not appear to be any way to disable this particular path through the uglifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants