Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] fixes redraw element when changing renderer #5233

Merged
merged 1 commit into from
Mar 20, 2019
Merged

[Android] fixes redraw element when changing renderer #5233

merged 1 commit into from
Mar 20, 2019

Conversation

paymicro
Copy link
Contributor

@paymicro paymicro commented Feb 13, 2019 •
edited
Loading

Description of Change

Added calling RequestLayout on parent Layout when adding child in current Layout.
Related PR #4861

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

  • run UItest 1760
  • run UItest 1760 (1)
  • run UItest 1332
  • run UItest 5184

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts
Copy link
Member

@paymicro I'm going to go ahead and revert #4861 from 3.5. Please redo those changes here in this PR. We'll target 3.6 for resolving #1760. Thanks!

@samhouts samhouts added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Feb 13, 2019
@samhouts samhouts changed the base branch from 3.5.0 to 3.6.0 February 13, 2019 22:07
@paymicro paymicro force-pushed the paymicro/fix-gh5184 branch from cc51d1d to 33ea542 Compare February 15, 2019 12:23
@paymicro paymicro added a/layout and removed DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. labels Feb 15, 2019
@samhouts samhouts requested a review from hartez February 22, 2019 01:03
@samhouts samhouts removed their assignment Feb 22, 2019
@samhouts samhouts changed the base branch from 3.6.0 to master February 28, 2019 20:04
@samhouts samhouts changed the base branch from master to 4.0.0 March 15, 2019 22:19
@samhouts samhouts merged commit ee01ce0 into 4.0.0 Mar 20, 2019
@samhouts samhouts deleted the paymicro/fix-gh5184 branch March 20, 2019 17:32
@samhouts samhouts added this to the 4.0.0 milestone Mar 28, 2019
@paymicro paymicro mentioned this pull request Jun 3, 2019
Merged
3 tasks
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
[Android] fixes redraw element when changing renderer (xamarin#5233)
df113d9 
fixes xamarin#1760
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts left review comments

@kingces95 kingces95 kingces95 approved these changes

@hartez hartez hartez approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

Assignees

@hartez hartez

@kingces95 kingces95

Labels
a/layout approved Has two approvals, no pending reviews, and no changes requested i/regression p/Android t/bug 🐛
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@paymicro @samhouts @hartez @kingces95